From 46ea5b68a99bd8bfde6cb6e19624290b2d634dd4 Mon Sep 17 00:00:00 2001 From: Safia Abdalla Date: Wed, 30 Nov 2016 22:37:03 -0600 Subject: [PATCH] events: remove unneeded safety check code In the process of creating #9865, it was discovered that the code checking whether or not events was defined was unnecessary because the only situation in which events would be undefined is if it is monkeypatched by an external entity. This should be removed in order to discourage this. If the test added in #9865 is merged, it will need to removed on merge of this commit. --- lib/events.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/events.js b/lib/events.js index e7202bfedd0c55..f2702f3d15445c 100644 --- a/lib/events.js +++ b/lib/events.js @@ -423,17 +423,13 @@ EventEmitter.prototype.listeners = function listeners(type) { var ret; var events = this._events; - if (!events) + evlistener = events[type]; + if (!evlistener) ret = []; - else { - evlistener = events[type]; - if (!evlistener) - ret = []; - else if (typeof evlistener === 'function') - ret = [evlistener.listener || evlistener]; - else - ret = unwrapListeners(evlistener); - } + else if (typeof evlistener === 'function') + ret = [evlistener.listener || evlistener]; + else + ret = unwrapListeners(evlistener); return ret; };