From fa4cc2807efb4cee08d6fc381d0904fe0ed814f9 Mon Sep 17 00:00:00 2001 From: Junshu Okamoto Date: Fri, 9 Sep 2016 14:13:46 -0700 Subject: [PATCH 1/4] =?UTF-8?q?test:=20favor=20=E2=80=99=3D=3D=3D=E2=80=99?= =?UTF-8?q?=20=20over=20=20in=20=E2=80=99=3D=3D=E2=80=99=20in=20http=20tes?= =?UTF-8?q?t?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test/parallel/test-http.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-http.js b/test/parallel/test-http.js index 102567fc2b42a7..775c19066d0d86 100644 --- a/test/parallel/test-http.js +++ b/test/parallel/test-http.js @@ -10,7 +10,7 @@ var body0 = ''; var body1 = ''; var server = http.Server(function(req, res) { - if (responses_sent == 0) { + if (responses_sent === 0) { assert.equal('GET', req.method); assert.equal('/hello', url.parse(req.url).pathname); @@ -22,7 +22,7 @@ var server = http.Server(function(req, res) { assert.equal('bar', req.headers['foo']); } - if (responses_sent == 1) { + if (responses_sent === 1) { assert.equal('POST', req.method); assert.equal('/world', url.parse(req.url).pathname); this.close(); From 9f3bf4214ec8046bfc1e7f7835e01c0b4c0cfc97 Mon Sep 17 00:00:00 2001 From: Junshu Okamoto Date: Fri, 9 Sep 2016 14:37:18 -0700 Subject: [PATCH 2/4] =?UTF-8?q?test:=20favor=20=E2=80=99assert.strictEqual?= =?UTF-8?q?=E2=80=99=20=20over=20=20in=20=E2=80=99assert.equal=E2=80=99=20?= =?UTF-8?q?in=20http=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test/parallel/test-http.js | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/test/parallel/test-http.js b/test/parallel/test-http.js index 775c19066d0d86..516c351bed21c9 100644 --- a/test/parallel/test-http.js +++ b/test/parallel/test-http.js @@ -11,20 +11,20 @@ var body1 = ''; var server = http.Server(function(req, res) { if (responses_sent === 0) { - assert.equal('GET', req.method); - assert.equal('/hello', url.parse(req.url).pathname); + assert.strictEqual('GET', req.method); + assert.strictEqual('/hello', url.parse(req.url).pathname); console.dir(req.headers); - assert.equal(true, 'accept' in req.headers); - assert.equal('*/*', req.headers['accept']); + assert.strictEqual(true, 'accept' in req.headers); + assert.strictEqual('*/*', req.headers['accept']); - assert.equal(true, 'foo' in req.headers); - assert.equal('bar', req.headers['foo']); + assert.strictEqual(true, 'foo' in req.headers); + assert.strictEqual('bar', req.headers['foo']); } if (responses_sent === 1) { - assert.equal('POST', req.method); - assert.equal('/world', url.parse(req.url).pathname); + assert.strictEqual('POST', req.method); + assert.strictEqual('/world', url.parse(req.url).pathname); this.close(); } @@ -48,7 +48,7 @@ server.on('listening', function() { headers: {'Accept': '*/*', 'Foo': 'bar'}, agent: agent }, function(res) { - assert.equal(200, res.statusCode); + assert.strictEqual(200, res.statusCode); responses_recvd += 1; res.setEncoding('utf8'); res.on('data', function(chunk) { body0 += chunk; }); @@ -62,7 +62,7 @@ server.on('listening', function() { path: '/world', agent: agent }, function(res) { - assert.equal(200, res.statusCode); + assert.strictEqual(200, res.statusCode); responses_recvd += 1; res.setEncoding('utf8'); res.on('data', function(chunk) { body1 += chunk; }); @@ -74,12 +74,11 @@ server.on('listening', function() { process.on('exit', function() { console.error('responses_recvd: ' + responses_recvd); - assert.equal(2, responses_recvd); + assert.strictEqual(2, responses_recvd); console.error('responses_sent: ' + responses_sent); - assert.equal(2, responses_sent); + assert.strictEqual(2, responses_sent); - assert.equal('The path was /hello', body0); - assert.equal('The path was /world', body1); + assert.strictEqual('The path was /hello', body0); + assert.strictEqual('The path was /world', body1); }); - From d52d5e11ee5007ddd21446d08750cfa3ffbe9fa1 Mon Sep 17 00:00:00 2001 From: Junshu Okamoto Date: Fri, 9 Sep 2016 15:21:33 -0700 Subject: [PATCH 3/4] =?UTF-8?q?test:=20favor=20=E2=80=99const=E2=80=99=20?= =?UTF-8?q?=20over=20=20in=20=E2=80=99var=E2=80=99=20in=20http=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test/parallel/test-http.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-http.js b/test/parallel/test-http.js index 516c351bed21c9..f3589c1209cba5 100644 --- a/test/parallel/test-http.js +++ b/test/parallel/test-http.js @@ -9,7 +9,7 @@ var responses_recvd = 0; var body0 = ''; var body1 = ''; -var server = http.Server(function(req, res) { +const server = http.Server(function(req, res) { if (responses_sent === 0) { assert.strictEqual('GET', req.method); assert.strictEqual('/hello', url.parse(req.url).pathname); @@ -41,7 +41,7 @@ var server = http.Server(function(req, res) { server.listen(0); server.on('listening', function() { - var agent = new http.Agent({ port: this.address().port, maxSockets: 1 }); + const agent = new http.Agent({ port: this.address().port, maxSockets: 1 }); http.get({ port: this.address().port, path: '/hello', @@ -56,7 +56,7 @@ server.on('listening', function() { }); setTimeout(function() { - var req = http.request({ + const req = http.request({ port: server.address().port, method: 'POST', path: '/world', From b05c4e8467ea8804508cdea6248d9b0c602871fb Mon Sep 17 00:00:00 2001 From: Junshu Okamoto Date: Mon, 12 Sep 2016 13:10:52 -0700 Subject: [PATCH 4/4] test: favor `const` over in `var` for require in http test --- test/parallel/test-http.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-http.js b/test/parallel/test-http.js index f3589c1209cba5..f755bca8bc74ec 100644 --- a/test/parallel/test-http.js +++ b/test/parallel/test-http.js @@ -1,8 +1,8 @@ 'use strict'; require('../common'); -var assert = require('assert'); -var http = require('http'); -var url = require('url'); +const assert = require('assert'); +const http = require('http'); +const url = require('url'); var responses_sent = 0; var responses_recvd = 0;