From faa464cb48980533954d27308a99552fe334433f Mon Sep 17 00:00:00 2001
From: Igor Sheludko <isheludko@gmail.com>
Date: Mon, 24 Jun 2024 10:42:18 +0200
Subject: [PATCH] src: fix implementation of `PropertySetterCallback`

V8 does not allow returning arbitrary values from the interceptor
setter callbacks, only a boolean return value is allowed. Since
default return value is `true`, it's not even necessary to set
the return value on a successful path.

Refs: https://crbug.com/348660658
---
 src/node_contextify.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/node_contextify.cc b/src/node_contextify.cc
index 2b08aee16c8e43..b31b0c4dfc7aab 100644
--- a/src/node_contextify.cc
+++ b/src/node_contextify.cc
@@ -567,7 +567,6 @@ Intercepted ContextifyContext::PropertySetterCallback(
     // property
     if (desc_obj->HasOwnProperty(context, env->get_string()).FromMaybe(false) ||
         desc_obj->HasOwnProperty(context, env->set_string()).FromMaybe(false)) {
-      args.GetReturnValue().Set(value);
       return Intercepted::kYes;
     }
   }