From e90f13c723b6cf7fcde1138ef708b84526e10997 Mon Sep 17 00:00:00 2001 From: emirgoren Date: Sun, 27 Nov 2022 10:27:00 +0300 Subject: [PATCH 1/2] doc: using console.error for error cases in crypto and events --- doc/api/crypto.md | 4 ++-- doc/api/events.md | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/api/crypto.md b/doc/api/crypto.md index b0f7eefa020067..2e03ffb9a5e39a 100644 --- a/doc/api/crypto.md +++ b/doc/api/crypto.md @@ -49,7 +49,7 @@ let crypto; try { crypto = require('node:crypto'); } catch (err) { - console.log('crypto support is disabled!'); + console.error('crypto support is disabled!'); } ``` @@ -67,7 +67,7 @@ let crypto; try { crypto = await import('node:crypto'); } catch (err) { - console.log('crypto support is disabled!'); + console.error('crypto support is disabled!'); } ``` diff --git a/doc/api/events.md b/doc/api/events.md index e776e0ec4017d1..37f8f99b1b39e3 100644 --- a/doc/api/events.md +++ b/doc/api/events.md @@ -1041,7 +1041,7 @@ process.nextTick(() => { try { await once(ee, 'myevent'); } catch (err) { - console.log('error happened', err); + console.error('error happened', err); } ``` @@ -1066,7 +1066,7 @@ async function run() { try { await once(ee, 'myevent'); } catch (err) { - console.log('error happened', err); + console.error('error happened', err); } } @@ -1085,7 +1085,7 @@ const ee = new EventEmitter(); once(ee, 'error') .then(([err]) => console.log('ok', err.message)) - .catch((err) => console.log('error', err.message)); + .catch((err) => console.error('error', err.message)); ee.emit('error', new Error('boom')); @@ -1099,7 +1099,7 @@ const ee = new EventEmitter(); once(ee, 'error') .then(([err]) => console.log('ok', err.message)) - .catch((err) => console.log('error', err.message)); + .catch((err) => console.error('error', err.message)); ee.emit('error', new Error('boom')); @@ -1120,7 +1120,7 @@ async function foo(emitter, event, signal) { console.log('event emitted!'); } catch (error) { if (error.name === 'AbortError') { - console.error('Waiting for the event was canceled!'); + console.log('Waiting for the event was canceled!'); } else { console.error('There was an error', error.message); } From 61dbaed1e64c4a1d5907a31e01b9c513605c2dc0 Mon Sep 17 00:00:00 2001 From: emirgoren Date: Sun, 27 Nov 2022 10:38:44 +0300 Subject: [PATCH 2/2] fixed line --- doc/api/events.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/events.md b/doc/api/events.md index 37f8f99b1b39e3..8f46eca4b49822 100644 --- a/doc/api/events.md +++ b/doc/api/events.md @@ -1120,7 +1120,7 @@ async function foo(emitter, event, signal) { console.log('event emitted!'); } catch (error) { if (error.name === 'AbortError') { - console.log('Waiting for the event was canceled!'); + console.error('Waiting for the event was canceled!'); } else { console.error('There was an error', error.message); }