From 97b3f58e29b2922c7104cfeb124b0d7fef0f4167 Mon Sep 17 00:00:00 2001 From: kuriyosh Date: Fri, 19 Nov 2021 16:19:30 +0900 Subject: [PATCH 1/2] test: improve test coverage of readline/promises --- test/parallel/test-readline-promises-interface.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/test/parallel/test-readline-promises-interface.js b/test/parallel/test-readline-promises-interface.js index 79803f99c19450..02d3dc04d7bdb6 100644 --- a/test/parallel/test-readline-promises-interface.js +++ b/test/parallel/test-readline-promises-interface.js @@ -910,6 +910,21 @@ for (let i = 0; i < 12; i++) { rli.close(); } + // Throw an error when question is executed with an aborted signal + { + const ac = new AbortController(); + const signal = ac.signal; + ac.abort(); + const [rli] = getInterface({ terminal }); + assert.rejects( + rli.question('hello?', { signal }), + { + code: 'ABORT_ERR' + } + ); + rli.close(); + } + // Can create a new readline Interface with a null output argument { const [rli, fi] = getInterface({ output: null, terminal }); From c3ca76ae7331824c3323ad1557a728ec561924db Mon Sep 17 00:00:00 2001 From: kuriyosh Date: Fri, 19 Nov 2021 17:50:00 +0900 Subject: [PATCH 2/2] test: handle the case rejects resolved with no error --- test/parallel/test-readline-promises-interface.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-readline-promises-interface.js b/test/parallel/test-readline-promises-interface.js index 02d3dc04d7bdb6..e137886fa19690 100644 --- a/test/parallel/test-readline-promises-interface.js +++ b/test/parallel/test-readline-promises-interface.js @@ -919,9 +919,9 @@ for (let i = 0; i < 12; i++) { assert.rejects( rli.question('hello?', { signal }), { - code: 'ABORT_ERR' + name: 'AbortError' } - ); + ).then(common.mustCall()); rli.close(); }