From 7f29637b19c875809434a42626b8074c0a51cdf6 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 2 Jun 2020 13:21:40 +0200 Subject: [PATCH 1/2] build: add LINT_CPP_FILES to checkimports check This commit adds the prerequisites which contains all the files to lint. Currently the only the files in 'src' will be checked. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 519e920685177f..7fa645f21dd9c9 100644 --- a/Makefile +++ b/Makefile @@ -1334,7 +1334,7 @@ lint-cpp: tools/.cpplintstamp tools/.cpplintstamp: $(LINT_CPP_FILES) @echo "Running C++ linter..." @$(PYTHON) tools/cpplint.py $(CPPLINT_QUIET) $? - @$(PYTHON) tools/checkimports.py + @$(PYTHON) tools/checkimports.py $? @touch $@ .PHONY: lint-addon-docs From 5f5c1fd8639adb471cb56e0824f0b10149be1cab Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 2 Jun 2020 13:27:45 +0200 Subject: [PATCH 2/2] tools: remove unused using declarations code_cache This commit removes the reported unused using declarations from cache_builder.cc --- tools/code_cache/cache_builder.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/code_cache/cache_builder.cc b/tools/code_cache/cache_builder.cc index 28d61a6c70c467..837357a0fbda76 100644 --- a/tools/code_cache/cache_builder.cc +++ b/tools/code_cache/cache_builder.cc @@ -13,10 +13,7 @@ namespace node { namespace native_module { using v8::Context; -using v8::Function; -using v8::Isolate; using v8::Local; -using v8::MaybeLocal; using v8::ScriptCompiler; static std::string GetDefName(const std::string& id) {