From 4c6ef4b7e28afb31228ce29bf3a20f94b90554dc Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 5 Mar 2020 23:07:49 -0800 Subject: [PATCH 1/2] test: apply camelCase in test-net-reconnect-error Rename two idnetifiers that were snake_case rather than camelCase. Signed-off-by: Rich Trott PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Robert Nagy --- test/sequential/test-net-reconnect-error.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/sequential/test-net-reconnect-error.js b/test/sequential/test-net-reconnect-error.js index e16d567c0ad1bb..30c7612c271d47 100644 --- a/test/sequential/test-net-reconnect-error.js +++ b/test/sequential/test-net-reconnect-error.js @@ -24,24 +24,24 @@ const common = require('../common'); const net = require('net'); const assert = require('assert'); const N = 20; -let client_error_count = 0; -let disconnect_count = 0; +let clientErrorCount = 0; +let disconnectCount = 0; const c = net.createConnection(common.PORT); c.on('connect', common.mustNotCall('client should not have connected')); c.on('error', common.mustCall((e) => { - client_error_count++; + clientErrorCount++; assert.strictEqual(e.code, 'ECONNREFUSED'); }, N + 1)); c.on('close', common.mustCall(() => { - if (disconnect_count++ < N) + if (disconnectCount++ < N) c.connect(common.PORT); // reconnect }, N + 1)); process.on('exit', function() { - assert.strictEqual(disconnect_count, N + 1); - assert.strictEqual(client_error_count, N + 1); + assert.strictEqual(disconnectCount, N + 1); + assert.strictEqual(clientErrorCount, N + 1); }); From 1b35e8402f890a7b7c9b701a0d2f61cf39a0fc7c Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 5 Mar 2020 23:12:19 -0800 Subject: [PATCH 2/2] test: remove superfluous checks in test-net-reconnect-error The process.on('exit', ...) checks duplicate the work of `common.mustCall()` and are superfluous. Remove them. Signed-off-by: Rich Trott PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Robert Nagy --- test/sequential/test-net-reconnect-error.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/test/sequential/test-net-reconnect-error.js b/test/sequential/test-net-reconnect-error.js index 30c7612c271d47..93d8f3673abda4 100644 --- a/test/sequential/test-net-reconnect-error.js +++ b/test/sequential/test-net-reconnect-error.js @@ -24,7 +24,6 @@ const common = require('../common'); const net = require('net'); const assert = require('assert'); const N = 20; -let clientErrorCount = 0; let disconnectCount = 0; const c = net.createConnection(common.PORT); @@ -32,7 +31,6 @@ const c = net.createConnection(common.PORT); c.on('connect', common.mustNotCall('client should not have connected')); c.on('error', common.mustCall((e) => { - clientErrorCount++; assert.strictEqual(e.code, 'ECONNREFUSED'); }, N + 1)); @@ -40,8 +38,3 @@ c.on('close', common.mustCall(() => { if (disconnectCount++ < N) c.connect(common.PORT); // reconnect }, N + 1)); - -process.on('exit', function() { - assert.strictEqual(disconnectCount, N + 1); - assert.strictEqual(clientErrorCount, N + 1); -});