From 79d678fc457ef6ef18bcd42708fa9cba47705bcb Mon Sep 17 00:00:00 2001 From: Jayasankar Date: Sat, 17 Nov 2018 17:03:24 +0530 Subject: [PATCH 1/4] test:replace anonymous closure function --- .../test-http-pipeline-socket-parser-typeerror.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-http-pipeline-socket-parser-typeerror.js b/test/parallel/test-http-pipeline-socket-parser-typeerror.js index 0cb20e76172766..8987b822c26496 100644 --- a/test/parallel/test-http-pipeline-socket-parser-typeerror.js +++ b/test/parallel/test-http-pipeline-socket-parser-typeerror.js @@ -20,7 +20,7 @@ let more; let done; const server = http - .createServer(function(req, res) { + .createServer((req, res) => { if (!once) server.close(); once = true; @@ -41,18 +41,18 @@ const server = http } done(); }) - .on('upgrade', function(req, socket) { - second.end(chunk, function() { + .on('upgrade', (req, socket) => { + second.end(chunk, () => { socket.end(); }); first.end('hello'); }) - .listen(0, function() { - const s = net.connect(this.address().port); - more = function() { + .listen(0, () => { + const s = net.connect(server.address().port); + more = () => { s.write('GET / HTTP/1.1\r\n\r\n'); }; - done = function() { + done = () => { s.write( 'GET / HTTP/1.1\r\n\r\n' + 'GET / HTTP/1.1\r\nConnection: upgrade\r\nUpgrade: ws\r\n\r\naaa' From 98d3a5df50b5739607b664d2adc8ed8cab738828 Mon Sep 17 00:00:00 2001 From: Jayasankar Date: Mon, 19 Nov 2018 06:10:27 +0530 Subject: [PATCH 2/4] src: elevate v8 namespaces of node_trace_events.cc --- src/node_trace_events.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc index 44cf31ff2e02d5..48c2c353e8e994 100644 --- a/src/node_trace_events.cc +++ b/src/node_trace_events.cc @@ -17,6 +17,7 @@ using v8::Local; using v8::Object; using v8::String; using v8::Value; +using v8::NewStringType; class NodeCategorySet : public BaseObject { public: @@ -91,7 +92,7 @@ void GetEnabledCategories(const FunctionCallbackInfo& args) { args.GetReturnValue().Set( String::NewFromUtf8(env->isolate(), categories.c_str(), - v8::NewStringType::kNormal, + NewStringType::kNormal, categories.size()).ToLocalChecked()); } } From 4f601e63391b6ca4ef9475f98e48bdef7898a9a2 Mon Sep 17 00:00:00 2001 From: Jayasankar Date: Mon, 19 Nov 2018 06:25:35 +0530 Subject: [PATCH 3/4] src: elevate v8 namespaces of node_trace_events.cc --- src/node_trace_events.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc index 48c2c353e8e994..249a5b90d95fa6 100644 --- a/src/node_trace_events.cc +++ b/src/node_trace_events.cc @@ -14,10 +14,11 @@ using v8::Context; using v8::FunctionCallbackInfo; using v8::FunctionTemplate; using v8::Local; +using v8::NewStringType; using v8::Object; using v8::String; using v8::Value; -using v8::NewStringType; + class NodeCategorySet : public BaseObject { public: From 01d6d3715841ca8e77f05f5e4096d2831ad49402 Mon Sep 17 00:00:00 2001 From: Jayasankar Date: Mon, 19 Nov 2018 13:23:32 +0530 Subject: [PATCH 4/4] src: elevate v8 namespaces of node_trace_events.cc --- src/node_trace_events.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc index 249a5b90d95fa6..94ed1ec5a1de5b 100644 --- a/src/node_trace_events.cc +++ b/src/node_trace_events.cc @@ -19,7 +19,6 @@ using v8::Object; using v8::String; using v8::Value; - class NodeCategorySet : public BaseObject { public: static void New(const FunctionCallbackInfo& args);