From e5244e5dbc37144d724eeee3bde2a844625c9664 Mon Sep 17 00:00:00 2001 From: Emily Kolar Date: Fri, 12 Oct 2018 11:38:17 -0700 Subject: [PATCH 1/2] test: correct order of assert args in client response domain test --- test/parallel/test-http-client-response-domain.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http-client-response-domain.js b/test/parallel/test-http-client-response-domain.js index 0a32e929141e45..32a6e8ad6d2668 100644 --- a/test/parallel/test-http-client-response-domain.js +++ b/test/parallel/test-http-client-response-domain.js @@ -45,7 +45,7 @@ server.listen(common.PIPE, function() { function test() { d.on('error', common.mustCall(function(err) { - assert.strictEqual('should be caught by domain', err.message); + assert.strictEqual(err.message, 'should be caught by domain'); })); const req = http.get({ From 8f4353e151ee6bc172cc1b5a1803e9ec34ef17b4 Mon Sep 17 00:00:00 2001 From: Emily Kolar Date: Sun, 14 Oct 2018 05:23:27 -0700 Subject: [PATCH 2/2] replace onerror callback with arrow function --- test/parallel/test-http-client-response-domain.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http-client-response-domain.js b/test/parallel/test-http-client-response-domain.js index 32a6e8ad6d2668..617dc729acb71f 100644 --- a/test/parallel/test-http-client-response-domain.js +++ b/test/parallel/test-http-client-response-domain.js @@ -44,7 +44,7 @@ server.listen(common.PIPE, function() { function test() { - d.on('error', common.mustCall(function(err) { + d.on('error', common.mustCall((err) => { assert.strictEqual(err.message, 'should be caught by domain'); }));