From 09011f0c1ce11074e09317114626393517c9bd37 Mon Sep 17 00:00:00 2001 From: Benjamin Coe Date: Thu, 31 May 2018 17:33:21 -0700 Subject: [PATCH] build: fail on instrumentation errors nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js. Refs: #20952 --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a7099947c72a78..27275a93f86107 100644 --- a/Makefile +++ b/Makefile @@ -176,7 +176,8 @@ coverage-build: all "$(CURDIR)/build/jenkins/scripts/coverage/gcovr-patches-3.4.diff"); fi if [ -d lib_ ]; then $(RM) -r lib; mv lib_ lib; fi mv lib lib_ - $(NODE) ./node_modules/.bin/nyc instrument --extension .js --extension .mjs lib_/ lib/ + NODE_DEBUG=nyc $(NODE) ./node_modules/.bin/nyc instrument --extension .js \ + --extension .mjs --exit-on-error lib_/ lib/ $(MAKE) .PHONY: coverage-test