From 9d1b178ad4541131f6f996ac2d677ef54186351e Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 14 Nov 2017 07:24:58 +0100 Subject: [PATCH] src: fix compiler warning from SetAccessor Currently the following compiler warning is displayed when building: ../src/node.cc:3270:12: warning: 'SetAccessor' is deprecated [-Wdeprecated-declarations] process->SetAccessor(FIXED_ONE_BYTE_STRING(env->isolate(), "ppid"), ^ ../deps/v8/include/v8.h:3184:22: note: 'SetAccessor' has been explicitly marked deprecated here bool SetAccessor(Local name, This commit updates the call to use the Maybe version. --- src/node.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/node.cc b/src/node.cc index cced5e7f8f81dd..eb2cf5a6a9e62e 100644 --- a/src/node.cc +++ b/src/node.cc @@ -3267,8 +3267,9 @@ void SetupProcessObject(Environment* env, READONLY_PROPERTY(process, "pid", Integer::New(env->isolate(), getpid())); READONLY_PROPERTY(process, "features", GetFeatures(env)); - process->SetAccessor(FIXED_ONE_BYTE_STRING(env->isolate(), "ppid"), - GetParentProcessId); + process->SetAccessor(env->context(), + FIXED_ONE_BYTE_STRING(env->isolate(), "ppid"), + GetParentProcessId).FromJust(); auto need_immediate_callback_string = FIXED_ONE_BYTE_STRING(env->isolate(), "_needImmediateCallback");