From cc9fe1b5cda588114595f4b803f6bb18d2d2a712 Mon Sep 17 00:00:00 2001 From: Chase Starr Date: Fri, 16 Dec 2016 17:28:59 -0800 Subject: [PATCH 1/2] doc: clarify macosx-firewall suggestion BUILDING `./tools/macosx-firewall.sh` fails if run before build step. Since the suggestion comes before the build steps in the document, this change clarifies that the script should be run after building. --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index b1962d53c2caf4..e38203be48628e 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -24,7 +24,7 @@ On OS X, you will also need: this under the menu `Xcode -> Preferences -> Downloads` * This step will install `gcc` and the related toolchain containing `make` -* You may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid +* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid popups asking to accept incoming network connections when running tests: ```console From 8684c62d2eb7fc27cd6bc7d053140af4987dacdf Mon Sep 17 00:00:00 2001 From: Chase Starr Date: Sat, 17 Dec 2016 13:06:59 -0800 Subject: [PATCH 2/2] doc: fix long line in BUILDING.md --- BUILDING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index e38203be48628e..b98bb75d79b656 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -24,8 +24,8 @@ On OS X, you will also need: this under the menu `Xcode -> Preferences -> Downloads` * This step will install `gcc` and the related toolchain containing `make` -* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid -popups asking to accept incoming network connections when running tests: +* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) +to avoid popups asking to accept incoming network connections when running tests: ```console $ sudo ./tools/macosx-firewall.sh