Windows: addons cannot use the bundled OpenSSL

[murgatroid99]

This is basically a copy of nodejs/node-v0.x-archive#4051, since it looks like that repository is obsolete and the problem still exists in the latest version of Node.

In the Node development package on Windows, the include directory has an openssl subdirectory with all of the OpenSSL headers, but the node.lib libraries do not export those symbols to link against.

This means that any Node extension that wants to use OpenSSL must instruct its users to follow the instructions at https://github.com/nodejs/node-gyp/wiki/Linking-to-OpenSSL#windows.

[murgatroid99]

As a side note, the headers in include/node/openssl/ seem to be the same, or very similar, to the headers in deps/openssl/openssl/include/openssl/ on Linux. For the purposes of node-gyp, module authors are instructed to include the latter path on systems where Node exports OpenSSL symbols, but to use a different include path on Windows. However, because the headers are also in the former path, they are included anyway and can conflict with the included headers on Windows.

[rvagg]

@nodejs/platform-windows ping, we need some expertise here, I can't answer this but am ready to help out where needed if we need to take action

[saper]

As a part of the build process one of the libraries generated is lib/openssl.lib:

  6177422  01-10-16 04:26   lib/cares.lib
 12294090  01-10-16 04:26   lib/gtest.lib
   117192  01-10-16 04:26   lib/http_parser.lib
  5619094  01-10-16 04:26   lib/libuv.lib
 70660776  01-10-16 04:26   lib/openssl.lib
   744562  01-10-16 04:26   lib/zlib.lib

Maybe ass a temporary workaround we should just publish those?

[bnoordhuis]

Fixed by #6274.

[murgatroid99]

I don't think this was ever actually fixed. I can't find a header distribution for any Node version that allows me to link against the built-in OpenSSL symbols on Windows, but the header is still there so there is still this conflict.