tracking issue: MSVC regression for 16.x and 14.x vs2022

[gengjiawen]

I am just wondering if we should open an issue to track/identify this problem?

Sure. I also tried to report the bug to MSVC team yesterday, but report bug entrance only in visual studio on windows which I don't have for now.

I've already reported this bug to MSVC team issue ticket

Originally posted by @euphy-wong in #42299 (comment)

Links: #42200

Hope MS will fix soon.

[F3n67u]

seems still no progress on the Microsoft side, I add a comment on the Microsoft ticket to try to push the progress of the investigation.

[dennisameling]

It looks like the fix has been released by MS in VS 2022 17.3 a few days ago 🎉 I was able to build 16.x (x64) successfully using that VS version locally. The GitHub Actions runners are still on 17.2, but those images are updated weekly, so I wouldn't be surprised if they update to 17.3 in the next two weeks or so.

The issue with building the main branch remains even after this update, but there's a separate issue for that already.

[dennisameling]

GitHub Actions Runner image version 20220821.1 contains MSVC 14.33 which includes the fix for this bug. Here's a PR to re-enable windows-2022 for 16.x: #44365

14.x doesn't have support in vcbuild.bat to detect VS 2022, so enabling it in CI there won't work. The PR that added support for it even explicitly has the dont-land-on-14.x label on it. 14.x also uses a lower version of gyp (0.7.0) while support for VS2022 was added only in 0.10.0.

[targos]

Can we close this issue?