Time to play with V8 4.6

[targos]

Now that 4.5 is on master, we can start working on the vee-eight-4.6 integration branch.
I upgraded V8 to 4.6.85.12 (https://github.com/nodejs/node/tree/vee-eight-4.6). Sadly I cannot make it to compile. Here is the error I get:

node [vee-eight-4.6] % make 
make -C out BUILDTYPE=Release V=1
make[1]: Entering directory '/home/mzasso/git/targos/node/out'
  g++ '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' -I../deps/v8  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -B/home/mzasso/git/targos/node/third_party/binutils/Linux_x64/Release/bin -fno-strict-aliasing -m64 -O3 -ffunction-sections -fdata-sections -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O3 -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /home/mzasso/git/targos/node/out/Release/.deps//home/mzasso/git/targos/node/out/Release/obj.target/v8_base/gen/debug-support.o.d.raw  -c -o /home/mzasso/git/targos/node/out/Release/obj.target/v8_base/gen/debug-support.o /home/mzasso/git/targos/node/out/Release/obj/gen/debug-support.cc
/home/mzasso/git/targos/node/out/Release/obj/gen/debug-support.cc:385:49: error: ‘kInObjectPropertiesOffset’ is not a member of ‘v8::internal::Map’
 int v8dbg_class_Map__inobject_properties__int = Map::kInObjectPropertiesOffset;
                                                 ^
deps/v8/tools/gyp/v8_base.target.mk:420: recipe for target '/home/mzasso/git/targos/node/out/Release/obj.target/v8_base/gen/debug-support.o' failed
make[1]: *** [/home/mzasso/git/targos/node/out/Release/obj.target/v8_base/gen/debug-support.o] Error 1
make[1]: Leaving directory '/home/mzasso/git/targos/node/out'
Makefile:45: recipe for target 'node' failed
make: *** [node] Error 2

I am able to compile d8 without any issue on the same version.

/cc @nodejs/v8

[indutny]

They broke it again! 😢

[targos]

Hold on, 4.6.85.13 was just released with a fix from @ofrobots 🎉

[targos]

OK it's all working on my side, here is a first CI: https://ci.nodejs.org/job/node-test-commit/501/
I did not apply any floating patch yet, something may be missing.

[ofrobots]

@McFarts Here's the V8 team's blog post on 4.6: http://v8project.blogspot.de/2015/08/v8-release-46.html

There are no plans that I am aware of to add shared-memory multi-threading to V8 as JavaScript is single threaded as per the language spec. Perhaps your multi-core use-cases can be addressed by the cluster module, or perhaps by workers (#2133) if/when they end up landing in Node.

[Fishrock123]

When do you think they will enable memory sharing across cores? I need my global variables and data to be... you know.. really global :P If you know what I mean

Knowing your aforementioned use case (game server?) I think you should focus on other optimizations. You can't multi-thread that in JavaScript.

[Fishrock123]

@McFarts Could you please ask this on stack-overflow instead? This really isn't the place for the questions you are asking.

[kkoopa]

NAN 2.0.8 test suite passes.

[ChALkeR]

Could you please check if #2793 works in 4.6?

[ChALkeR]

v8 4.6.85.19 should fix #2793.

[targos]

I just rebased vee-eight-4.6 on master and included the backports from 4.7 that I could:

• acb6779, 4e028bd, 75fe773 and c22bcd3 applied cleanly.
• 31450fc and 2b8a06b introduce conflicts. cc @indutny

[trevnorris]

This ready for a CI run?

[targos]

https://ci.nodejs.org/job/node-test-commit/674/

[targos]

... the .gitignore trolled me again: https://github.com/nodejs/node/blob/master/.gitignore#L26

[targos]

OK now it's compiling: https://ci.nodejs.org/job/node-test-commit/675/