-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Closed
Labels
trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.
Description
We noticed these two sites as potential null pointer deferences.
Lines 51 to 53 in ebbf393
const uint8_t* category_group_enabled = | |
GetCategoryGroupEnabled(category_group); | |
if (*category_group_enabled == 0) return; |
Lines 130 to 132 in ebbf393
const uint8_t* category_group_enabled = | |
GetCategoryGroupEnabled(category_group); | |
args.GetReturnValue().Set(*category_group_enabled > 0); |
It seems like category_group_enabled
can be null based on the defensive check:
Lines 19 to 23 in ebbf393
static const uint8_t* GetCategoryGroupEnabled(const char* category_group) { | |
if (category_group == nullptr) return nullptr; | |
return TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED(category_group); | |
} |
But I suspect because of the usage GetCategoryGroupEnabled
is not called with null pointer. Any thoughts?
Metadata
Metadata
Assignees
Labels
trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.Issues and PRs related to V8, Node.js core, and userspace code trace events.