Skip to content

Commit fd21b92

Browse files
committed
Review notes fixed
1 parent ee643bd commit fd21b92

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

test/parallel/test-cluster-worker-disconnect.js

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
var common = require('../common');
22
var assert = require('assert');
33
var cluster = require('cluster');
4-
var fs = require('fs');
5-
var path = require('path');
64

75
if (cluster.isWorker) {
86
var http = require('http');
97
http.Server(function() {
108

119
}).listen(common.PORT, '127.0.0.1');
1210

13-
// Save flag-file on disconnect
1411
cluster.worker.on('disconnect', function(){
15-
fs.writeFileSync(path.join(__dirname, process.pid + ''), '');
12+
process.exit(42);
1613
});
1714

1815
} else if (cluster.isMaster) {
@@ -67,17 +64,10 @@ if (cluster.isWorker) {
6764
});
6865

6966
// Check that the worker died
70-
worker.once('exit', function() {
67+
worker.once('exit', function(code) {
7168
checks.worker.emitExit = true;
7269
checks.worker.died = !alive(worker.process.pid);
73-
74-
var flagFile = path.join(__dirname, worker.process.pid + '');
75-
checks.worker.emitDisconnectInsideWorker = fs.existsSync(flagFile);
76-
77-
// cleanup
78-
if (checks.worker.emitDisconnectInsideWorker) {
79-
fs.unlinkSync(flagFile);
80-
}
70+
checks.worker.emitDisconnectInsideWorker = code === 42;
8171

8272
process.nextTick(function() {
8373
process.exit(0);

0 commit comments

Comments
 (0)