Skip to content

Commit e61344a

Browse files
yhwanggibfahn
authored andcommitted
build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux. The appending is defined in node.gypi and the cctest target in node.gyp includes node.gypi. Moving the appending from node.gypi to node target in node.gyp fixes the issue. Signed-off-by: Yihong Wang <[email protected]> PR-URL: #16680 Backport-PR-URL: #17258 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 87a893b commit e61344a

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

node.gypi

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,6 @@
1111
'defines': [
1212
'NODE_SHARED_MODE',
1313
],
14-
'conditions': [
15-
[ 'node_module_version!="" and OS!="win"', {
16-
'product_extension': '<(shlib_suffix)',
17-
}]
18-
],
1914
}],
2015
[ 'node_enable_d8=="true"', {
2116
'dependencies': [ 'deps/v8/src/d8.gyp:d8' ],

0 commit comments

Comments
 (0)