Skip to content

Commit db5c314

Browse files
committed
build: fail on CI if leftover processes
If any tests leave processes running after testing results are complete, fail the test run.
1 parent 1162e28 commit db5c314

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

Makefile

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,13 +290,23 @@ test-ci-js: | clear-stalled
290290
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
291291
--mode=release --flaky-tests=$(FLAKY_TESTS) \
292292
$(TEST_CI_ARGS) $(CI_JS_SUITES)
293+
# Clean up any leftover processes
294+
PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
295+
if [ "$${PS_OUT}" ]; then \
296+
echo $${PS_OUT} | $(XARGS) kill; exit 1; \
297+
fi
293298

294299
test-ci: LOGLEVEL := info
295300
test-ci: | clear-stalled build-addons
296301
out/Release/cctest --gtest_output=tap:cctest.tap
297302
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
298303
--mode=release --flaky-tests=$(FLAKY_TESTS) \
299304
$(TEST_CI_ARGS) $(CI_NATIVE_SUITES) $(CI_JS_SUITES)
305+
# Clean up any leftover processes
306+
PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
307+
if [ "$${PS_OUT}" ]; then \
308+
echo $${PS_OUT} | $(XARGS) kill; exit 1; \
309+
fi
300310

301311
test-release: test-build
302312
$(PYTHON) tools/test.py --mode=release

0 commit comments

Comments
 (0)