Skip to content

Commit c17ff62

Browse files
erinishimotichaMylesBorins
authored andcommitted
deps: cherry-pick f4a2b7f3 from V8 upstream.
Original commit message: should ignore asyncTask* with null In V8Debugger code we don't expect task_id == null, e.g. asyncTaskStartedForStepping will trigger debug break on null as task_id. Let's filter task_id == null out. This issue is originally filed in Node.js: #15464 [email protected] Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c Reviewed-on: https://chromium-review.googlesource.com/695808 Reviewed-by: Dmitry Gozman <[email protected]> Commit-Queue: Aleksey Kozyatinskiy <[email protected]> Cr-Commit-Position: refs/heads/master@{#48265} Fixes #15464 PR-URL: #16053 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent d2e1545 commit c17ff62

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

deps/v8/src/inspector/v8-inspector-impl.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,18 +286,22 @@ std::unique_ptr<V8StackTrace> V8InspectorImpl::captureStackTrace(
286286

287287
void V8InspectorImpl::asyncTaskScheduled(const StringView& taskName, void* task,
288288
bool recurring) {
289+
if (!task) return;
289290
m_debugger->asyncTaskScheduled(taskName, task, recurring);
290291
}
291292

292293
void V8InspectorImpl::asyncTaskCanceled(void* task) {
294+
if (!task) return;
293295
m_debugger->asyncTaskCanceled(task);
294296
}
295297

296298
void V8InspectorImpl::asyncTaskStarted(void* task) {
299+
if (!task) return;
297300
m_debugger->asyncTaskStarted(task);
298301
}
299302

300303
void V8InspectorImpl::asyncTaskFinished(void* task) {
304+
if (!task) return;
301305
m_debugger->asyncTaskFinished(task);
302306
}
303307

0 commit comments

Comments
 (0)