benchmark: swap var for let in buffer benchmarks

In benchmark buffers directory this changes for loops using var to let
when it applies for consistency

PR-URL: #28867
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

Author: RamirezAlex

benchmark/buffers/buffer-base64-decode-wrapped.js

@@ -18,7 +18,7 @@ function main({ charsPerLine, linesCount, n }) {
   const buffer = Buffer.alloc(bytesCount, line, 'base64');
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     buffer.base64Write(data, 0, bytesCount);
   }
   bench.end(n);

benchmark/buffers/buffer-base64-decode.js

@@ -16,6 +16,6 @@ function main({ n, size }) {
   const b = Buffer.allocUnsafe(encodedSize);
   b.write(s, 0, encodedSize, 'base64');
   bench.start();
-  for (var i = 0; i < n; i += 1) b.base64Write(s, 0, s.length);
+  for (let i = 0; i < n; i += 1) b.base64Write(s, 0, s.length);
   bench.end(n);
 }

benchmark/buffers/buffer-bytelength.js

@@ -37,7 +37,7 @@ function main({ n, len, encoding }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     const index = n % strings.length;
     // Go!
     const r = Buffer.byteLength(strings[index], encoding);

benchmark/buffers/buffer-compare-offset.js

@@ -8,12 +8,12 @@ const bench = common.createBenchmark(main, {
 });
 
 function compareUsingSlice(b0, b1, len, iter) {
-  for (var i = 0; i < iter; i++)
+  for (let i = 0; i < iter; i++)
     Buffer.compare(b0.slice(1, len), b1.slice(1, len));
 }
 
 function compareUsingOffset(b0, b1, len, iter) {
-  for (var i = 0; i < iter; i++)
+  for (let i = 0; i < iter; i++)
     b0.compare(b1, 1, len, 1, len);
 }
 

benchmark/buffers/buffer-compare.js

@@ -34,7 +34,7 @@ function main({ n, size }) {
   b1[size - 1] = 'b'.charCodeAt(0);
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     Buffer.compare(b0, b1);
   }
   bench.end(n);

benchmark/buffers/buffer-concat.js

@@ -15,7 +15,7 @@ function main({ n, pieces, pieceSize, withTotalLength }) {
   const totalLength = withTotalLength ? pieces * pieceSize : undefined;
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     Buffer.concat(list, totalLength);
   }
   bench.end(n);

benchmark/buffers/buffer-indexof-number.js

@@ -15,7 +15,7 @@ function main({ n, value }) {
 
   let count = 0;
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     count += aliceBuffer.indexOf(value, 0, undefined);
   }
   bench.end(n);

benchmark/buffers/buffer-indexof.js

@@ -42,7 +42,7 @@ function main({ n, search, encoding, type }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     aliceBuffer.indexOf(search, 0, encoding);
   }
   bench.end(n);

benchmark/buffers/buffer-normalize-encoding.js

@@ -31,7 +31,7 @@ function main({ encoding, n }) {
   const { normalizeEncoding } = require('internal/util');
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     normalizeEncoding(encoding);
   }
   bench.end(n);

benchmark/buffers/buffer-read-float.js

@@ -32,7 +32,7 @@ function main({ n, type, endian, value }) {
   buff[`write${type}${endian}`](values[type][value], 0);
 
   bench.start();
-  for (var i = 0; i !== n; i++) {
+  for (let i = 0; i !== n; i++) {
     buff[fn](0);
   }
   bench.end(n);