Skip to content

Commit afbd8df

Browse files
captainsafiaMylesBorins
authored andcommitted
test: increase coverage for lib/events.js
Adds tests for the case in which listeners() is invoked on a EventEmitter with no events. Adds a new test case for the situation in which a class inherits from the EventEmitter but overrides the constructor in the EventEmitter so that the _events is never set. PR-URL: #9865 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
1 parent 6632b3d commit afbd8df

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

test/parallel/test-event-emitter-listeners.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,12 @@
33
require('../common');
44
const assert = require('assert');
55
const events = require('events');
6+
const util = require('util');
67

78
function listener() {}
89
function listener2() {}
10+
class TestStream { constructor() { } }
11+
util.inherits(TestStream, events.EventEmitter);
912

1013
{
1114
const ee = new events.EventEmitter();
@@ -36,3 +39,14 @@ function listener2() {}
3639
assert.deepStrictEqual(ee.listeners('foo'), [listener, listener2]);
3740
assert.deepStrictEqual(eeListenersCopy, [listener]);
3841
}
42+
43+
{
44+
const ee = new events.EventEmitter();
45+
ee._events = undefined;
46+
assert.deepStrictEqual(ee.listeners('foo'), []);
47+
}
48+
49+
{
50+
const s = new TestStream();
51+
assert.deepStrictEqual(s.listeners('foo'), []);
52+
}

0 commit comments

Comments
 (0)