Skip to content

Commit af3315a

Browse files
committed
modify error code&msg, make client cb be called
1 parent d1e7667 commit af3315a

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed
Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,28 @@
11
'use strict';
22

33
const common = require('../common');
4+
const http = require('http');
45
const assert = require('assert');
56
const ClientRequest = require('http').ClientRequest;
67

78
{
8-
const req = new ClientRequest(() => {});
9-
req.on('error', common.mustCall((err) => {
10-
assert.strictEqual(err.code, 'ECONNREFUSED');
9+
const server = http.createServer(common.mustCall((req, res) => {
10+
res.writeHead(200);
11+
res.end('hello world');
12+
})).listen(80, '127.0.0.1');
13+
14+
const req = new ClientRequest(common.mustCall((response) => {
15+
let body = '';
16+
response.setEncoding('utf8');
17+
response.on('data', (chunk) => {
18+
body += chunk;
19+
});
20+
21+
response.on('end', common.mustCall(() => {
22+
assert.strictEqual(body, 'hello world');
23+
server.close();
24+
}));
1125
}));
12-
assert.strictEqual(req.path, '/');
13-
assert.strictEqual(req.method, 'GET');
26+
27+
req.end();
1428
}

test/parallel/test-http-client-insecure-http-parser-error.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const ClientRequest = require('http').ClientRequest;
88
assert.throws(() => {
99
new ClientRequest({ insecureHTTPParser: 'wrongValue' });
1010
}, {
11-
code: /ERR_INVALID_ARG_TYPE/
11+
code: 'ERR_INVALID_ARG_TYPE',
12+
message: /insecureHTTPParser/
1213
}, 'http request should throw when passing invalid insecureHTTPParser');
1314
}

0 commit comments

Comments
 (0)