1
1
<!--
2
- Thank you for submitting a pull request to Node.js. Before you submit, please
3
- review below requirements and walk through the checklist. You can 'tick'
4
- a box by using the letter "x": [x].
2
+ Thank you for your pull request. Please review below requirements and walk
3
+ through the checklist. You can 'tick' a box by using the letter "x": [x].
5
4
6
- Run the test suite by invoking : `make -j4 lint test` on linux or
7
- `vcbuild test nosign` on Windows.
5
+ Run the test suite with : `make -j4 test` on UNIX or `vcbuild test nosign` on
6
+ Windows.
8
7
9
8
If this aims to fix a regression or you’re adding a feature, make sure you also
10
- write a test. Finally – if possible – a benchmark that quantifies your changes.
9
+ write a test. If possible, include a benchmark that quantifies your changes.
11
10
12
11
Finally, read through our contributors guide and make adjustments as necessary:
13
12
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
14
13
-->
15
14
16
15
##### Checklist
17
-
18
16
<!-- remove lines that do not apply to you -->
19
17
20
18
- [ ] tests and code linting passes
@@ -24,10 +22,8 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
24
22
25
23
26
24
##### Affected core subsystem(s)
27
-
28
25
<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->
29
26
30
27
31
28
##### Description of change
32
-
33
29
<!-- provide a description of the change below this comment -->
0 commit comments