lib: add comments to empty catch statements

PR-URL: #41831
Backport-PR-URL: #42160
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

Author: Trott

lib/events.js

@@ -445,7 +445,9 @@ function enhanceStackTrace(err, own) {
     const { name } = this.constructor;
     if (name !== 'EventEmitter')
       ctorInfo = ` on ${name} instance`;
-  } catch {}
+  } catch {
+    // Continue regardless of error.
+  }
   const sep = `\nEmitted 'error' event${ctorInfo} at:\n`;
 
   const errStack = ArrayPrototypeSlice(
@@ -493,7 +495,9 @@ EventEmitter.prototype.emit = function emit(type, ...args) {
           value: FunctionPrototypeBind(enhanceStackTrace, this, er, capture),
           configurable: true
         });
-      } catch {}
+      } catch {
+        // Continue regardless of error.
+      }
 
       // Note: The comments on the `throw` lines are intentional, they show
       // up in Node's output if this results in an unhandled exception.

lib/fs.js

@@ -1600,7 +1600,9 @@ function symlink(target, path, type_, callback_) {
       // errors consistent between platforms if invalid path is
       // provided.
       absoluteTarget = pathModule.resolve(path, '..', target);
-    } catch { }
+    } catch {
+      // Continue regardless of error.
+    }
     if (absoluteTarget !== undefined) {
       stat(absoluteTarget, (err, stat) => {
         const resolvedType = !err && stat.isDirectory() ? 'dir' : 'file';

lib/internal/bootstrap/pre_execution.js

@@ -97,7 +97,9 @@ function patchProcessObject(expandArgv1) {
     const path = require('path');
     try {
       process.argv[1] = path.resolve(process.argv[1]);
-    } catch {}
+    } catch {
+      // Continue regardless of error.
+    }
   }
 
   // TODO(joyeecheung): most of these should be deprecated and removed,

lib/internal/error_serdes.js

@@ -48,7 +48,9 @@ function TryGetAllProperties(object, target = object) {
     if (getter && key !== '__proto__') {
       try {
         descriptor.value = FunctionPrototypeCall(getter, target);
-      } catch {}
+      } catch {
+        // Continue regardless of error.
+      }
     }
     if ('value' in descriptor && typeof descriptor.value !== 'function') {
       delete descriptor.get;
@@ -107,11 +109,15 @@ function serializeError(error) {
         }
       }
     }
-  } catch {}
+  } catch {
+    // Continue regardless of error.
+  }
   try {
     const serialized = serialize(error);
     return Buffer.concat([Buffer.from([kSerializedObject]), serialized]);
-  } catch {}
+  } catch {
+    // Continue regardless of error.
+  }
   return Buffer.concat([Buffer.from([kInspectedError]),
                         Buffer.from(inspect(error), 'utf8')]);
 }

lib/internal/main/worker_thread.js

@@ -224,14 +224,18 @@ function workerOnGlobalUncaughtException(error, fromPromise) {
       if (!handlerThrew) {
         process.emit('exit', process.exitCode);
       }
-    } catch {}
+    } catch {
+      // Continue regardless of error.
+    }
   }
 
   let serialized;
   try {
     const { serializeError } = require('internal/error_serdes');
     serialized = serializeError(error);
-  } catch {}
+  } catch {
+    // Continue regardless of error.
+  }
   debug(`[${threadId}] uncaught exception serialized = ${!!serialized}`);
   if (serialized)
     port.postMessage({

lib/internal/modules/cjs/loader.js

@@ -1134,7 +1134,9 @@ Module._extensions['.js'] = function(module, filename) {
         let parentSource;
         try {
           parentSource = fs.readFileSync(parentPath, 'utf8');
-        } catch {}
+        } catch {
+          // Continue regardless of error.
+        }
         if (parentSource) {
           const errLine = StringPrototypeSplit(
             StringPrototypeSlice(err.stack, StringPrototypeIndexOf(

lib/internal/modules/esm/module_job.js

@@ -154,7 +154,9 @@ class ModuleJob {
           // care about CommonJS for the purposes of this error message.
           ({ format } =
             await this.loader.load(childFileURL));
-        } catch {}
+        } catch {
+          // Continue regardless of error.
+        }
 
         if (format === 'commonjs') {
           const importStatement = splitStack[1];

lib/internal/modules/esm/resolve.js

@@ -498,7 +498,9 @@ function resolvePackageTargetString(
       try {
         new URL(target);
         isURL = true;
-      } catch {}
+      } catch {
+        // Continue regardless of error.
+      }
       if (!isURL) {
         const exportTarget = pattern ?
           RegExpPrototypeSymbolReplace(patternRegEx, target, () => subpath) :

lib/internal/modules/esm/translators.js

@@ -180,7 +180,9 @@ translators.set('commonjs', async function commonjsStrategy(url, source,
       let value;
       try {
         value = exports[exportName];
-      } catch {}
+      } catch {
+        // Continue regardless of error.
+      }
       this.setExport(exportName, value);
     }
     this.setExport('default', exports);
@@ -205,7 +207,9 @@ function cjsPreparseModuleExports(filename) {
   let source;
   try {
     source = readFileSync(filename, 'utf8');
-  } catch {}
+  } catch {
+    // Continue regardless of error.
+  }
 
   let exports, reexports;
   try {

lib/internal/policy/manifest.js

@@ -639,7 +639,9 @@ function canonicalizeSpecifier(specifier, base) {
       return resolve(specifier, base).href;
     }
     return resolve(specifier).href;
-  } catch {}
+  } catch {
+    // Continue regardless of error.
+  }
   return specifier;
 }