Skip to content

Commit a202be6

Browse files
bnoordhuisFishrock123
authored andcommitted
build: don't build icu with -fno-rtti
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
1 parent 31232ad commit a202be6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/icu/icu-generic.gyp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
[ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
6969
'cflags': [ '-Wno-deprecated-declarations' ],
7070
'cflags_cc': [ '-frtti' ],
71+
'cflags_cc!': [ '-fno-rtti' ],
7172
}],
7273
[ 'OS == "mac" or OS == "ios"', {
7374
'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },

0 commit comments

Comments
 (0)