Skip to content

Commit a12ff5c

Browse files
ChALkeRFishrock123
authored andcommitted
tools: clean up icu/README.md formatting
1. Normalize headings. 2. Specify language in all code blocks. PR-URL: #8660 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 7728f95 commit a12ff5c

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

tools/icu/README.md

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
Notes about the icu directory.
2-
===
1+
# Notes about the icu directory.
32

4-
How to upgrade ICU
5-
---
3+
## How to upgrade ICU
64

75
- Make sure your node workspace is clean (clean `git status`) should be sufficient.
86
- Configure Node with the specific [ICU version](http://icu-project.org/download) you want to upgrade to, for example:
97

10-
```
8+
```shell
119
./configure \
1210
--with-intl=small-icu \
1311
--with-icu-source=http://download.icu-project.org/files/icu4c/56.1/icu4c-56_1-src.zip
@@ -21,7 +19,7 @@ version specific stuff)
2119

2220
- Verify the node build works
2321

24-
```
22+
```shell
2523
make test-ci
2624
```
2725

@@ -36,15 +34,15 @@ Also running
3634

3735
- Now, copy `deps/icu` over to `deps/icu-small`
3836

39-
```
37+
```shell
4038
python tools/icu/shrink-icu-src.py
4139
```
4240

4341
- Now, do a clean rebuild of node to test:
4442

4543
(TODO: fix this when these options become default)
4644

47-
```
45+
```shell
4846
./configure --with-intl=small-icu --with-icu-source=deps/icu-small
4947
make
5048
```
@@ -64,7 +62,7 @@ This is a big commit, so make this a separate commit from other changes.
6462
the `configure_intl()` function. It should match the ICU URL used in the
6563
first step. When this is done, the following should build with full ICU.
6664

67-
```
65+
```shell
6866
# clean up
6967
rm -rf out deps/icu deps/icu4c*
7068
./configure --with-intl=full-icu --download=all
@@ -76,8 +74,7 @@ make test-ci
7674

7775
-----
7876

79-
Notes about these tools
80-
---
77+
## Notes about these tools
8178

8279
The files in this directory were written for the node.js effort. It's
8380
the intent of their author (Steven R. Loomis / srl295) to merge them

0 commit comments

Comments
 (0)