util: make util binding internal

Refs: #22160
PR-URL: #22675
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

Author: cjihrig

benchmark/util/type-check.js

@@ -38,7 +38,8 @@ function main({ type, argument, version, n }) {
   // For testing, if supplied with an empty type, default to ArrayBufferView.
   type = type || 'ArrayBufferView';
 
-  const util = process.binding('util');
+  const { internalBinding } = require('internal/test/binding');
+  const util = internalBinding('util');
   const types = require('internal/util/types');
 
   const func = { native: util, js: types }[version][`is${type}`];

lib/console.js

@@ -29,7 +29,8 @@ const {
     ERR_INVALID_ARG_VALUE,
   },
 } = require('internal/errors');
-const { previewEntries } = process.binding('util');
+const { internalBinding } = require('internal/bootstrap/loaders');
+const { previewEntries } = internalBinding('util');
 const { Buffer: { isBuffer } } = require('buffer');
 const util = require('util');
 const {

lib/internal/bootstrap/node.js

@@ -176,7 +176,7 @@
       // TODO(addaleax): Turn into a full runtime deprecation.
       const { pendingDeprecation } = process.binding('config');
       const { deprecate } = NativeModule.require('internal/util');
-      const utilBinding = process.binding('util');
+      const utilBinding = internalBinding('util');
       const types = internalBinding('types');
       for (const name of [
         'isArrayBuffer', 'isArrayBufferView', 'isAsyncFunction',
@@ -374,6 +374,7 @@
         'contextify',
         'tcp_wrap',
         'tls_wrap',
+        'util',
         'async_wrap']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?

lib/internal/modules/cjs/loader.js

@@ -21,7 +21,7 @@
 
 'use strict';
 
-const { NativeModule } = require('internal/bootstrap/loaders');
+const { internalBinding, NativeModule } = require('internal/bootstrap/loaders');
 const util = require('util');
 const vm = require('vm');
 const assert = require('assert').ok;
@@ -32,7 +32,7 @@ const {
   internalModuleReadJSON,
   internalModuleStat
 } = process.binding('fs');
-const { safeGetenv } = process.binding('util');
+const { safeGetenv } = internalBinding('util');
 const {
   makeRequireFunction,
   requireDepth,

lib/internal/process/promises.js

@@ -1,6 +1,7 @@
 'use strict';
 
-const { safeToString } = process.binding('util');
+const { internalBinding } = require('internal/bootstrap/loaders');
+const { safeToString } = internalBinding('util');
 
 const maybeUnhandledPromises = new WeakMap();
 const pendingUnhandledRejections = [];

lib/internal/util.js

@@ -6,15 +6,14 @@ const {
   ERR_UNKNOWN_SIGNAL
 } = require('internal/errors').codes;
 const { signals } = process.binding('constants').os;
-
+const { internalBinding } = require('internal/bootstrap/loaders');
 const {
   getHiddenValue,
   setHiddenValue,
   arrow_message_private_symbol: kArrowMessagePrivateSymbolIndex,
   decorated_private_symbol: kDecoratedPrivateSymbolIndex
-} = process.binding('util');
+} = internalBinding('util');
 
-const { internalBinding } = require('internal/bootstrap/loaders');
 const { errmap } = internalBinding('uv');
 
 const noCrypto = !process.versions.openssl;

lib/internal/util/comparisons.js

@@ -15,7 +15,7 @@ const {
   propertyFilter: {
     ONLY_ENUMERABLE
   }
-} = process.binding('util');
+} = internalBinding('util');
 
 const ReflectApply = Reflect.apply;
 

lib/os.js

@@ -21,7 +21,8 @@
 
 'use strict';
 
-const { pushValToArrayMax, safeGetenv } = process.binding('util');
+const { internalBinding } = require('internal/bootstrap/loaders');
+const { pushValToArrayMax, safeGetenv } = internalBinding('util');
 const constants = process.binding('constants').os;
 const { deprecate } = require('internal/util');
 const isWindows = process.platform === 'win32';

lib/repl.js

@@ -53,7 +53,8 @@ const {
 } = require('internal/deps/acorn/dist/acorn');
 const internalUtil = require('internal/util');
 const util = require('util');
-const utilBinding = process.binding('util');
+const { internalBinding } = require('internal/bootstrap/loaders');
+const utilBinding = internalBinding('util');
 const { inherits } = util;
 const Stream = require('stream');
 const vm = require('vm');
@@ -79,7 +80,7 @@ const {
     ALL_PROPERTIES,
     SKIP_SYMBOLS
   }
-} = process.binding('util');
+} = internalBinding('util');
 
 // Lazy-loaded.
 let processTopLevelAwait;

lib/stream.js

@@ -49,7 +49,8 @@ try {
   } else {
     // This throws for Node < 4.2.0 because there's no util binding and
     // returns undefined for Node < 7.4.0.
-    Stream._isUint8Array = process.binding('util').isUint8Array;
+    const { internalBinding } = require('internal/bootstrap/loaders');
+    Stream._isUint8Array = internalBinding('util').isUint8Array;
   }
 } catch (e) {
 }