Skip to content

Commit 7d105d7

Browse files
benchmark: moving construction from bench scope for find methods
1 parent 4ed4f78 commit 7d105d7

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

benchmark/es/error-stack.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
1010
'without-sourcemap',
1111
'sourcemap',
1212
'node-modules-without-sourcemap',
13-
'node-module-sourcemap'],
13+
'node-modules-sourcemap'],
1414
n: [1e5],
1515
});
1616

benchmark/source_map/source-map.js

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ function main({ operation, n }) {
6060
);
6161

6262
let sourceMap;
63+
let instance;
6364
switch (operation) {
6465
case 'parse':
6566
bench.start();
@@ -94,65 +95,73 @@ function main({ operation, n }) {
9495
break;
9596

9697
case 'findEntry':
98+
instance = new SourceMap(samplePayload);
9799
bench.start();
98100
for (let i = 0; i < n; i++) {
99-
sourceMap = new SourceMap(samplePayload).findEntry(i, i);
101+
sourceMap = instance.findEntry(i, i);
100102
}
101103
bench.end(n);
102104
break;
103105

104106
case 'findEntry-minified':
107+
instance = new SourceMap(minifiedPayload);
105108
bench.start();
106109
for (let i = 0; i < n; i++) {
107-
sourceMap = new SourceMap(minifiedPayload).findEntry(i, i);
110+
sourceMap = instance.findEntry(i, i);
108111
}
109112
bench.end(n);
110113
break;
111114

112115
case 'findEntry-sectioned':
116+
instance = new SourceMap(sectionedPayload);
113117
bench.start();
114118
for (let i = 0; i < n; i++) {
115-
sourceMap = new SourceMap(sectionedPayload).findEntry(i, i);
119+
sourceMap = instance.findEntry(i, i);
116120
}
117121
bench.end(n);
118122
break;
119123

120124
case 'findEntry-large':
125+
instance = new SourceMap(largePayload);
121126
bench.start();
122127
for (let i = 0; i < n; i++) {
123-
sourceMap = new SourceMap(largePayload).findEntry(i, i);
128+
sourceMap = instance.findEntry(i, i);
124129
}
125130
bench.end(n);
126131
break;
127132

128133
case 'findOrigin':
134+
instance = new SourceMap(samplePayload);
129135
bench.start();
130136
for (let i = 0; i < n; i++) {
131-
sourceMap = new SourceMap(samplePayload).findOrigin(i, i);
137+
sourceMap = instance.findOrigin(i, i);
132138
}
133139
bench.end(n);
134140
break;
135141

136142
case 'findOrigin-minified':
143+
instance = new SourceMap(minifiedPayload);
137144
bench.start();
138145
for (let i = 0; i < n; i++) {
139-
sourceMap = new SourceMap(minifiedPayload).findOrigin(i, i);
146+
sourceMap = instance.findOrigin(i, i);
140147
}
141148
bench.end(n);
142149
break;
143150

144151
case 'findOrigin-sectioned':
152+
instance = new SourceMap(sectionedPayload);
145153
bench.start();
146154
for (let i = 0; i < n; i++) {
147-
sourceMap = new SourceMap(sectionedPayload).findOrigin(i, i);
155+
sourceMap = instance.findOrigin(i, i);
148156
}
149157
bench.end(n);
150158
break;
151159

152160
case 'findOrigin-large':
161+
instance = new SourceMap(largePayload);
153162
bench.start();
154163
for (let i = 0; i < n; i++) {
155-
sourceMap = new SourceMap(largePayload).findOrigin(i, i);
164+
sourceMap = instance.findOrigin(i, i);
156165
}
157166
bench.end(n);
158167
break;

doc/contributing/writing-and-running-benchmarks.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ benchmarks. This increases the likelihood of each benchmark achieving peak perfo
101101
according to the hardware. Therefore, run:
102102

103103
```console
104-
$ ./benchmarks/cpu.sh fast
104+
$ ./benchmark/cpu.sh fast
105105
```
106106

107107
### Running individual benchmarks

0 commit comments

Comments
 (0)