Skip to content

Commit 6720539

Browse files
danbevMylesBorins
authored andcommitted
src: move node_trace_writer/buffer.h to agent.cc
The headers node_trace_writer.h and node_trace_buffer.h are not used in agent.h but are more of an implementation detail of agent.cc. This commit suggests moving the inclusion of these headers to agent.cc. PR-URL: #15598 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 9eeaab4 commit 6720539

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/tracing/agent.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
#include <sstream>
44
#include <string>
5+
#include "tracing/node_trace_buffer.h"
6+
#include "tracing/node_trace_writer.h"
57

68
#include "env-inl.h"
79

src/tracing/agent.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
#ifndef SRC_TRACING_AGENT_H_
22
#define SRC_TRACING_AGENT_H_
33

4+
#include "libplatform/v8-tracing.h"
45
#include "node_platform.h"
5-
#include "tracing/node_trace_buffer.h"
6-
#include "tracing/node_trace_writer.h"
76
#include "uv.h"
87
#include "v8.h"
98

109
namespace node {
1110
namespace tracing {
1211

12+
using v8::platform::tracing::TracingController;
13+
1314
class Agent {
1415
public:
1516
Agent();

0 commit comments

Comments
 (0)