test: use tmpdir.resolve()

Subsystems: blob, child_process, common, crypto, http, http2,
readline, repl, snapshot, trace_events

PR-URL: #49127
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>

Author: LiviaMedeiros

test/parallel/test-blob-file-backed.js

@@ -15,13 +15,12 @@ const {
 const {
   unlink
 } = require('fs/promises');
-const path = require('path');
 const { Blob } = require('buffer');
 
 const tmpdir = require('../common/tmpdir');
-const testfile = path.join(tmpdir.path, 'test-file-backed-blob.txt');
-const testfile2 = path.join(tmpdir.path, 'test-file-backed-blob2.txt');
-const testfile3 = path.join(tmpdir.path, 'test-file-backed-blob3.txt');
+const testfile = tmpdir.resolve('test-file-backed-blob.txt');
+const testfile2 = tmpdir.resolve('test-file-backed-blob2.txt');
+const testfile3 = tmpdir.resolve('test-file-backed-blob3.txt');
 tmpdir.refresh();
 
 const data = `${'a'.repeat(1000)}${'b'.repeat(2000)}`;

test/parallel/test-child-process-fork-exec-path.js

@@ -27,13 +27,12 @@ const common = require('../common');
 const tmpdir = require('../common/tmpdir');
 const { addLibraryPath } = require('../common/shared-lib-util');
 const assert = require('assert');
-const path = require('path');
 const fs = require('fs');
 const { fork } = require('child_process');
 
 const msg = { test: 'this' };
 const nodePath = process.execPath;
-const copyPath = path.join(tmpdir.path, 'node-copy.exe');
+const copyPath = tmpdir.resolve('node-copy.exe');
 
 addLibraryPath(process.env);
 

test/parallel/test-child-process-pipe-dataflow.js

@@ -1,7 +1,6 @@
 'use strict';
 const common = require('../common');
 const assert = require('assert');
-const path = require('path');
 const fs = require('fs');
 const spawn = require('child_process').spawn;
 const tmpdir = require('../common/tmpdir');
@@ -18,7 +17,7 @@ const MB = KB * KB;
 
 {
   tmpdir.refresh();
-  const file = path.resolve(tmpdir.path, 'data.txt');
+  const file = tmpdir.resolve('data.txt');
   const buf = Buffer.alloc(MB).fill('x');
 
   // Most OS commands that deal with data, attach special meanings to new line -

test/parallel/test-crypto-authenticated-stream.js

@@ -7,7 +7,6 @@ if (!common.hasCrypto)
 const assert = require('assert');
 const crypto = require('crypto');
 const fs = require('fs');
-const path = require('path');
 const stream = require('stream');
 const tmpdir = require('../common/tmpdir');
 
@@ -72,7 +71,7 @@ function mstream(config) {
 
 function fstream(config) {
   const count = fstream.count++;
-  const filename = (name) => path.join(tmpdir.path, `${name}${count}`);
+  const filename = (name) => tmpdir.resolve(`${name}${count}`);
 
   const { cipher, key, iv, aad, authTagLength, plaintextLength } = config;
   const expected = Buffer.alloc(plaintextLength);

test/parallel/test-crypto-sign-verify.js

@@ -5,7 +5,6 @@ if (!common.hasCrypto)
 
 const assert = require('assert');
 const fs = require('fs');
-const path = require('path');
 const exec = require('child_process').exec;
 const crypto = require('crypto');
 const fixtures = require('../common/fixtures');
@@ -617,9 +616,9 @@ assert.throws(
   const tmpdir = require('../common/tmpdir');
   tmpdir.refresh();
 
-  const sigfile = path.join(tmpdir.path, 's5.sig');
+  const sigfile = tmpdir.resolve('s5.sig');
   fs.writeFileSync(sigfile, s5);
-  const msgfile = path.join(tmpdir.path, 's5.msg');
+  const msgfile = tmpdir.resolve('s5.msg');
   fs.writeFileSync(msgfile, msg);
 
   const cmd =

test/parallel/test-http-agent-getname.js

@@ -3,7 +3,6 @@
 require('../common');
 const assert = require('assert');
 const http = require('http');
-const path = require('path');
 
 const tmpdir = require('../common/tmpdir');
 
@@ -41,7 +40,7 @@ assert.strictEqual(
 );
 
 // unix socket
-const socketPath = path.join(tmpdir.path, 'foo', 'bar');
+const socketPath = tmpdir.resolve('foo', 'bar');
 assert.strictEqual(
   agent.getName({
     socketPath

test/parallel/test-http-chunk-problem.js

@@ -39,7 +39,7 @@ const cp = require('child_process');
 
 const tmpdir = require('../common/tmpdir');
 
-const filename = require('path').join(tmpdir.path, 'big');
+const filename = tmpdir.resolve('big');
 let server;
 
 function executeRequest(cb) {

test/parallel/test-http-pipe-fs.js

@@ -23,7 +23,6 @@
 const common = require('../common');
 const http = require('http');
 const fs = require('fs');
-const path = require('path');
 const Countdown = require('../common/countdown');
 const NUMBER_OF_STREAMS = 2;
 
@@ -32,7 +31,7 @@ const countdown = new Countdown(NUMBER_OF_STREAMS, () => server.close());
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-const file = path.join(tmpdir.path, 'http-pipe-fs-test.txt');
+const file = tmpdir.resolve('http-pipe-fs-test.txt');
 
 const server = http.createServer(common.mustCall(function(req, res) {
   const stream = fs.createWriteStream(file);

test/parallel/test-http2-compat-serverrequest-pipe.js

@@ -7,14 +7,13 @@ const fixtures = require('../common/fixtures');
 const assert = require('assert');
 const http2 = require('http2');
 const fs = require('fs');
-const path = require('path');
 
 // Piping should work as expected with createWriteStream
 
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 const loc = fixtures.path('person-large.jpg');
-const fn = path.join(tmpdir.path, 'http2-url-tests.js');
+const fn = tmpdir.resolve('http2-url-tests.js');
 
 const server = http2.createServer();
 

test/parallel/test-http2-pipe-named-pipe.js

@@ -8,14 +8,13 @@ const assert = require('assert');
 const http2 = require('http2');
 const fs = require('fs');
 const net = require('net');
-const path = require('path');
 
 // HTTP/2 servers can listen on a named pipe.
 
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 const loc = fixtures.path('person-large.jpg');
-const fn = path.join(tmpdir.path, 'person-large.jpg');
+const fn = tmpdir.resolve('person-large.jpg');
 
 const server = http2.createServer();