Skip to content

Commit 6209a78

Browse files
committed
test: adapt test-fs-write to V8 internal changes
1 parent 23941ae commit 6209a78

File tree

1 file changed

+19
-6
lines changed

1 file changed

+19
-6
lines changed

test/parallel/test-fs-write.js

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,23 @@ const fn4 = path.join(tmpdir.path, 'write4.txt');
3636
const expected = 'ümlaut.';
3737
const constants = fs.constants;
3838

39-
const { externalizeString, isOneByteString } = global;
39+
const {
40+
createExternalizableString,
41+
externalizeString,
42+
isOneByteString,
43+
} = global;
4044

4145
// Account for extra globals exposed by --expose_externalize_string.
42-
common.allowGlobals(externalizeString, isOneByteString, global.x);
46+
common.allowGlobals(
47+
createExternalizableString,
48+
externalizeString,
49+
isOneByteString,
50+
global.x,
51+
);
4352

4453
{
45-
const expected = 'ümlaut sechzig'; // Must be a unique string.
54+
// Must be a unique string.
55+
const expected = createExternalizableString('ümlaut sechzig');
4656
externalizeString(expected);
4757
assert.strictEqual(isOneByteString(expected), true);
4858
const fd = fs.openSync(fn, 'w');
@@ -52,7 +62,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x);
5262
}
5363

5464
{
55-
const expected = 'ümlaut neunzig'; // Must be a unique string.
65+
// Must be a unique string.
66+
const expected = createExternalizableString('ümlaut neunzig');
5667
externalizeString(expected);
5768
assert.strictEqual(isOneByteString(expected), true);
5869
const fd = fs.openSync(fn, 'w');
@@ -62,7 +73,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x);
6273
}
6374

6475
{
65-
const expected = 'Zhōngwén 1'; // Must be a unique string.
76+
// Must be a unique string.
77+
const expected = createExternalizableString('Zhōngwén 1');
6678
externalizeString(expected);
6779
assert.strictEqual(isOneByteString(expected), false);
6880
const fd = fs.openSync(fn, 'w');
@@ -72,7 +84,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x);
7284
}
7385

7486
{
75-
const expected = 'Zhōngwén 2'; // Must be a unique string.
87+
// Must be a unique string.
88+
const expected = createExternalizableString('Zhōngwén 2');
7689
externalizeString(expected);
7790
assert.strictEqual(isOneByteString(expected), false);
7891
const fd = fs.openSync(fn, 'w');

0 commit comments

Comments
 (0)