Skip to content

Commit 5bd33f1

Browse files
sam-githubBridgeAR
sam-github
authored and
BridgeAR
committed
src: fix type mismatch warnings from missing priv
Registration initialization functions are expected to have a 4th argument, a void*, so add them where necessary to fix the warnings. PR-URL: #24737 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 9572008 commit 5bd33f1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+96
-45
lines changed

‎src/async_wrap.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,8 @@ Local<FunctionTemplate> AsyncWrap::GetConstructorTemplate(Environment* env) {
452452

453453
void AsyncWrap::Initialize(Local<Object> target,
454454
Local<Value> unused,
455-
Local<Context> context) {
455+
Local<Context> context,
456+
void* priv) {
456457
Environment* env = Environment::GetCurrent(context);
457458
Isolate* isolate = env->isolate();
458459
HandleScope scope(isolate);

‎src/async_wrap.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ class AsyncWrap : public BaseObject {
116116

117117
static void Initialize(v8::Local<v8::Object> target,
118118
v8::Local<v8::Value> unused,
119-
v8::Local<v8::Context> context);
119+
v8::Local<v8::Context> context,
120+
void* priv);
120121

121122
static void GetAsyncId(const v8::FunctionCallbackInfo<v8::Value>& args);
122123
static void PushAsyncIds(const v8::FunctionCallbackInfo<v8::Value>& args);

‎src/bootstrapper.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,8 @@ namespace symbols {
171171

172172
void Initialize(Local<Object> target,
173173
Local<Value> unused,
174-
Local<Context> context) {
174+
Local<Context> context,
175+
void* priv) {
175176
Environment* env = Environment::GetCurrent(context);
176177
#define V(PropertyName, StringValue) \
177178
target->Set(env->context(), \

‎src/cares_wrap.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2172,7 +2172,8 @@ void StrError(const FunctionCallbackInfo<Value>& args) {
21722172

21732173
void Initialize(Local<Object> target,
21742174
Local<Value> unused,
2175-
Local<Context> context) {
2175+
Local<Context> context,
2176+
void* priv) {
21762177
Environment* env = Environment::GetCurrent(context);
21772178

21782179
env->SetMethod(target, "getaddrinfo", GetAddrInfo);

‎src/fs_event_wrap.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ class FSEventWrap: public HandleWrap {
5252
public:
5353
static void Initialize(Local<Object> target,
5454
Local<Value> unused,
55-
Local<Context> context);
55+
Local<Context> context,
56+
void* priv);
5657
static void New(const FunctionCallbackInfo<Value>& args);
5758
static void Start(const FunctionCallbackInfo<Value>& args);
5859
static void GetInitialized(const FunctionCallbackInfo<Value>& args);
@@ -95,7 +96,8 @@ void FSEventWrap::GetInitialized(const FunctionCallbackInfo<Value>& args) {
9596

9697
void FSEventWrap::Initialize(Local<Object> target,
9798
Local<Value> unused,
98-
Local<Context> context) {
99+
Local<Context> context,
100+
void* priv) {
99101
Environment* env = Environment::GetCurrent(context);
100102

101103
auto fsevent_string = FIXED_ONE_BYTE_STRING(env->isolate(), "FSEvent");

‎src/heap_utils.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,8 @@ void CreateHeapDump(const FunctionCallbackInfo<Value>& args) {
247247

248248
void Initialize(Local<Object> target,
249249
Local<Value> unused,
250-
Local<Context> context) {
250+
Local<Context> context,
251+
void* priv) {
251252
Environment* env = Environment::GetCurrent(context);
252253

253254
env->SetMethodNoSideEffect(target, "buildEmbedderGraph", BuildEmbedderGraph);

‎src/js_stream.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,8 @@ void JSStream::EmitEOF(const FunctionCallbackInfo<Value>& args) {
196196

197197
void JSStream::Initialize(Local<Object> target,
198198
Local<Value> unused,
199-
Local<Context> context) {
199+
Local<Context> context,
200+
void* priv) {
200201
Environment* env = Environment::GetCurrent(context);
201202

202203
Local<FunctionTemplate> t = env->NewFunctionTemplate(New);

‎src/js_stream.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ class JSStream : public AsyncWrap, public StreamBase {
1414
public:
1515
static void Initialize(v8::Local<v8::Object> target,
1616
v8::Local<v8::Value> unused,
17-
v8::Local<v8::Context> context);
17+
v8::Local<v8::Context> context,
18+
void* priv);
1819

1920
bool IsAlive() override;
2021
bool IsClosing() override;

‎src/module_wrap.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,8 @@ void ModuleWrap::SetInitializeImportMetaObjectCallback(
821821

822822
void ModuleWrap::Initialize(Local<Object> target,
823823
Local<Value> unused,
824-
Local<Context> context) {
824+
Local<Context> context,
825+
void* priv) {
825826
Environment* env = Environment::GetCurrent(context);
826827
Isolate* isolate = env->isolate();
827828

‎src/module_wrap.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ class ModuleWrap : public BaseObject {
3838
static const std::string EXTENSIONS[];
3939
static void Initialize(v8::Local<v8::Object> target,
4040
v8::Local<v8::Value> unused,
41-
v8::Local<v8::Context> context);
41+
v8::Local<v8::Context> context,
42+
void* priv);
4243
static void HostInitializeImportMetaObjectCallback(
4344
v8::Local<v8::Context> context,
4445
v8::Local<v8::Module> module,

0 commit comments

Comments
 (0)