Skip to content

Commit 4c9ab75

Browse files
committed
benchmark: remove deprecated argument
The benchmarks for dns.lookup() include calling it with an empty hostname which results in a deprecation warning. This benchmark seems to be subject to some odd side effects (see Ref below) and we probably generally don't want to benchmark deprecated things by default anyway. Remove the deprecated value from the default list. Bonus is that this will speed up the benchmark. Refs: #27081 (comment)
1 parent c86883c commit 4c9ab75

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

benchmark/dns/lookup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const common = require('../common.js');
44
const lookup = require('dns').lookup;
55

66
const bench = common.createBenchmark(main, {
7-
name: ['', '127.0.0.1', '::1'],
7+
name: ['127.0.0.1', '::1'],
88
all: ['true', 'false'],
99
n: [5e6]
1010
});

0 commit comments

Comments
 (0)