lib: make domexception a native error

Co-Authored-By: Kenta Moriuchi <[email protected]>

Author: legendecas

lib/internal/per_context/domexception.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const {
-  ErrorCaptureStackTrace,
+  Error,
   ErrorPrototype,
   ObjectDefineProperties,
   ObjectDefineProperty,
@@ -60,20 +60,32 @@ const disusedNamesSet = new SafeSet()
   .add('NoDataAllowedError')
   .add('ValidationError');
 
+let DOMExceptionPrototype;
+// The DOMException WebIDL interface defines that:
+// - ObjectGetPrototypeOf(DOMException) === Function.
+// - ObjectGetPrototypeOf(DOMException.prototype) === Error.prototype.
+// Thus, we can not simply use the pattern of `class DOMException extends Error` and call
+// `super()` to construct an object. The `super` in `super()` call in the constructor will
+// resolved to `Function`, instead of `Error`.
+// Ref: https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-getsuperconstructor
 class DOMException {
   constructor(message = '', options = 'Error') {
-    this[transfer_mode_private_symbol] = kCloneable;
-    ErrorCaptureStackTrace(this);
+    // Invokes the Error constructor to create an object with the [[ErrorData]]
+    // internal slot.
+    // eslint-disable-next-line no-restricted-syntax
+    const self = new Error();
+    ObjectSetPrototypeOf(self, DOMExceptionPrototype);
+    self[transfer_mode_private_symbol] = kCloneable;
 
     if (options && typeof options === 'object') {
       const { name } = options;
-      internalsMap.set(this, {
+      internalsMap.set(self, {
         message: `${message}`,
         name: `${name}`,
       });
 
       if ('cause' in options) {
-        ObjectDefineProperty(this, 'cause', {
+        ObjectDefineProperty(self, 'cause', {
           __proto__: null,
           value: options.cause,
           configurable: true,
@@ -82,11 +94,14 @@ class DOMException {
         });
       }
     } else {
-      internalsMap.set(this, {
+      internalsMap.set(self, {
         message: `${message}`,
         name: `${options}`,
       });
     }
+    // Return the error object as the return override of the constructor.
+    // eslint-disable-next-line no-constructor-return
+    return self;
   }
 
   [messaging_clone_symbol]() {
@@ -142,8 +157,9 @@ class DOMException {
   }
 }
 
-ObjectSetPrototypeOf(DOMException.prototype, ErrorPrototype);
-ObjectDefineProperties(DOMException.prototype, {
+DOMExceptionPrototype = DOMException.prototype;
+ObjectSetPrototypeOf(DOMExceptionPrototype, ErrorPrototype);
+ObjectDefineProperties(DOMExceptionPrototype, {
   [SymbolToStringTag]: { __proto__: null, configurable: true, value: 'DOMException' },
   name: { __proto__: null, enumerable: true, configurable: true },
   message: { __proto__: null, enumerable: true, configurable: true },
@@ -181,7 +197,7 @@ for (const { 0: name, 1: codeName, 2: value } of [
 ]) {
   const desc = { enumerable: true, value };
   ObjectDefineProperty(DOMException, codeName, desc);
-  ObjectDefineProperty(DOMException.prototype, codeName, desc);
+  ObjectDefineProperty(DOMExceptionPrototype, codeName, desc);
   nameToCodeMap.set(name, value);
 }
 

test/wpt/status/webidl/ecmascript-binding/es-exceptions.json

@@ -1,10 +1 @@
-{
-  "DOMException-is-error.any.js": {
-    "fail": {
-      "note": "https://github.com/nodejs/node/issues/56497",
-      "expected": [
-        "DOMException-is-error"
-      ]
-    }
-  }
-}
+{}