test: remove cjs loader from stack traces

Author: GeoffreyBooth

test/errors/throw-error-with-getter-throw-traced.mjs

@@ -0,0 +1,27 @@
+import { spawnPromisified } from '../common/index.mjs';
+import assert from 'node:assert';
+import { execPath } from 'node:process';
+import { describe, it } from 'node:test';
+
+
+describe('--trace-uncaught', () => {
+  it('prints a trace on process exit for uncaught errors', async () => {
+    const { code, signal, stderr } = await spawnPromisified(execPath, [
+      '--trace-uncaught',
+      '--eval',
+      `throw {
+        get stack() {
+          throw new Error('weird throw but ok');
+        },
+        get name() {
+          throw new Error('weird throw but ok');
+        },
+      };`,
+    ]);
+
+    assert.match(stderr, /Thrown at:/);
+    assert.match(stderr, /    at \[eval\]:1:1/);
+    assert.strictEqual(code, 1);
+    assert.strictEqual(signal, null);
+  });
+});

test/errors/throw-null-traced.mjs

@@ -0,0 +1,20 @@
+import { spawnPromisified } from '../common/index.mjs';
+import assert from 'node:assert';
+import { execPath } from 'node:process';
+import { describe, it } from 'node:test';
+
+
+describe('--trace-uncaught', () => {
+  it('prints a trace on process exit for uncaught errors', async () => {
+    const { code, signal, stderr } = await spawnPromisified(execPath, [
+      '--trace-uncaught',
+      '--eval',
+      'throw null;',
+    ]);
+
+    assert.match(stderr, /Thrown at:/);
+    assert.match(stderr, /    at \[eval\]:1:1/);
+    assert.strictEqual(code, 1);
+    assert.strictEqual(signal, null);
+  });
+});

test/errors/throw-undefined-traced.mjs

@@ -0,0 +1,20 @@
+import { spawnPromisified } from '../common/index.mjs';
+import assert from 'node:assert';
+import { execPath } from 'node:process';
+import { describe, it } from 'node:test';
+
+
+describe('--trace-uncaught', () => {
+  it('prints a trace on process exit for uncaught errors', async () => {
+    const { code, signal, stderr } = await spawnPromisified(execPath, [
+      '--trace-uncaught',
+      '--eval',
+      'throw undefined;',
+    ]);
+
+    assert.match(stderr, /Thrown at:/);
+    assert.match(stderr, /    at \[eval\]:1:1/);
+    assert.strictEqual(code, 1);
+    assert.strictEqual(signal, null);
+  });
+});

test/message/core_line_numbers.js

@@ -1,5 +1,7 @@
 'use strict';
 require('../common');
+Error.stackTraceLimit = 3;
+
 const punycode = require('punycode');
 
 // This test verifies that line numbers in core modules are reported correctly.

test/message/core_line_numbers.out

@@ -6,11 +6,5 @@ RangeError: Invalid input
     at error (node:punycode:52:8)
     at Object.decode (node:punycode:*:*)
     at Object.<anonymous> (*test*message*core_line_numbers.js:*:*)
-    at Module._compile (node:internal/modules/cjs/loader:*:*)
-    at Module._extensions..js (node:internal/modules/cjs/loader:*:*)
-    at Module.load (node:internal/modules/cjs/loader:*:*)
-    at Module._load (node:internal/modules/cjs/loader:*:*)
-    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:*:*)
-    at node:internal/main/run_main_module:*:*
 
 Node.js *

test/message/error_aggregateTwoErrors.js

@@ -2,6 +2,8 @@
 'use strict';
 
 require('../common');
+Error.stackTraceLimit = 1;
+
 const { aggregateTwoErrors } = require('internal/errors');
 
 const originalError = new Error('original');

test/message/error_aggregateTwoErrors.out

@@ -1,34 +1,15 @@
 *error_aggregateTwoErrors.js:*
 throw aggregateTwoErrors(err, originalError);
 ^
-AggregateError: original
-    at Object.<anonymous> (*test*message*error_aggregateTwoErrors.js:*:*)
-    at Module._compile (node:internal/modules/cjs/loader:*:*)
-    at Module._extensions..js (node:internal/modules/cjs/loader:*:*)
-    at Module.load (node:internal/modules/cjs/loader:*:*)
-    at Module._load (node:internal/modules/cjs/loader:*:*)
-    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:*:*)
-    at node:internal/main/run_main_module:*:* {
+[AggregateError: original] {
   code: 'ERR0',
   [errors]: [
     Error: original
-        at Object.<anonymous> (*test*message*error_aggregateTwoErrors.js:*:*)
-        at Module._compile (node:internal/modules/cjs/loader:*:*)
-        at Module._extensions..js (node:internal/modules/cjs/loader:*:*)
-        at Module.load (node:internal/modules/cjs/loader:*:*)
-        at Module._load (node:internal/modules/cjs/loader:*:*)
-        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:*:*)
-        at node:internal/main/run_main_module:*:* {
+        at Object.<anonymous> (/Users/geoffrey/Sites/node/test/message/error_aggregateTwoErrors.js:*:*) {
       code: 'ERR0'
     },
     Error: second error
-        at Object.<anonymous> (*test*message*error_aggregateTwoErrors.js:*:*)
-        at Module._compile (node:internal/modules/cjs/loader:*:*)
-        at Module._extensions..js (node:internal/modules/cjs/loader:*:*)
-        at Module.load (node:internal/modules/cjs/loader:*:*)
-        at Module._load (node:internal/modules/cjs/loader:*:*)
-        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:*:*)
-        at node:internal/main/run_main_module:*:* {
+        at Object.<anonymous> (/Users/geoffrey/Sites/node/test/message/error_aggregateTwoErrors.js:*:*) {
       code: 'ERR1'
     }
   ]

test/message/error_exit.js

@@ -21,6 +21,8 @@
 
 'use strict';
 require('../common');
+Error.stackTraceLimit = 1;
+
 const assert = require('assert');
 
 process.on('exit', function(code) {

test/message/error_exit.out

@@ -7,13 +7,7 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
 
 1 !== 2
 
-    at Object.<anonymous> (*test*message*error_exit.js:*:*)
-    at Module._compile (node:internal/modules/cjs/loader:*:*)
-    at Module._extensions..js (node:internal/modules/cjs/loader:*:*)
-    at Module.load (node:internal/modules/cjs/loader:*:*)
-    at Module._load (node:internal/modules/cjs/loader:*:*)
-    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:*:*)
-    at node:internal/main/run_main_module:*:* {
+    at Object.<anonymous> (*test*message*error_exit.js:*:*) {
   generatedMessage: true,
   code: 'ERR_ASSERTION',
   actual: 1,

test/message/error_with_nul.js

@@ -1,5 +1,6 @@
 'use strict';
 require('../common');
+Error.stackTraceLimit = 2;
 
 function test() {
   const a = 'abc\0def';