fixup: clear storage early

apapirovski · apapirovski · commit 21f0e82e7705 · 2018-04-28T16:56:40.000+02:00
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -1366,14 +1366,15 @@ void Http2Session::ClearOutgoing(int status) {
   CHECK_NE(flags_ & SESSION_STATE_SENDING, 0);
 
   if (outgoing_buffers_.size() > 0) {
+    outgoing_storage_.clear();
+
     for (const nghttp2_stream_write& wr : outgoing_buffers_) {
       WriteWrap* wrap = wr.req_wrap;
       if (wrap != nullptr)
         wrap->Done(status);
     }
 
     outgoing_buffers_.clear();
-    outgoing_storage_.clear();
   }
 
   flags_ &= ~SESSION_STATE_SENDING;

Original file line number	Diff line number	Diff line change
`@@ -1366,14 +1366,15 @@ void Http2Session::ClearOutgoing(int status) {`
`1366`	`1366`	`CHECK_NE(flags_ & SESSION_STATE_SENDING, 0);`
`1367`	`1367`
`1368`	`1368`	`if (outgoing_buffers_.size() > 0) {`
	`1369`	`+ outgoing_storage_.clear();`
	`1370`	`+`
`1369`	`1371`	`for (const nghttp2_stream_write& wr : outgoing_buffers_) {`
`1370`	`1372`	`WriteWrap* wrap = wr.req_wrap;`
`1371`	`1373`	`if (wrap != nullptr)`
`1372`	`1374`	`wrap->Done(status);`
`1373`	`1375`	`}`
`1374`	`1376`
`1375`	`1377`	`outgoing_buffers_.clear();`
`1376`		`- outgoing_storage_.clear();`
`1377`	`1378`	`}`
`1378`	`1379`
`1379`	`1380`	`flags_ &= ~SESSION_STATE_SENDING;`