Skip to content

Commit 1d47e32

Browse files
fixup! readline: fix unicode line separators being ignored
also include \r\n in test
1 parent 984f8a1 commit 1d47e32

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-readline-line-separators.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const assert = require('node:assert');
44
const readline = require('node:readline');
55
const { Readable } = require('node:stream');
66

7-
const str = '123\n456\r789\u{2028}ABC\u{2029}DEF';
7+
const str = '012\n345\r67\r\n89\u{2028}ABC\u{2029}DEF';
88

99
const rli = new readline.Interface({
1010
input: Readable.from(str),
@@ -14,7 +14,7 @@ const linesRead = [];
1414
rli.on('line', (line) => linesRead.push(line));
1515

1616
rli.on('close', common.mustCall(() => {
17-
const regexpLines = str.split(/^/m).map((line) => line.trim());
17+
const regexpLines = str.split(/^/m).map((line) => line.trim()).filter(Boolean);
1818
// Readline interprets different lines in the same way js regular expressions do
1919
assert.deepStrictEqual(linesRead, regexpLines);
2020
}));

0 commit comments

Comments
 (0)