test: make import common as the first line

The `test/common` module has the capability to identify if any variable
is leaked to the global scope and fail the test. So that has to be
imported at the beginning.

PR-URL: #7786
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

Author: thefourtheye

test/debugger/helper-debugger-repl.js

@@ -1,9 +1,9 @@
 'use strict';
-process.env.NODE_DEBUGGER_TIMEOUT = 2000;
-var common = require('../common');
+const common = require('../common');
 var assert = require('assert');
 var spawn = require('child_process').spawn;
 
+process.env.NODE_DEBUGGER_TIMEOUT = 2000;
 var port = common.PORT;
 
 var child;

test/debugger/test-debug-break-on-uncaught.js

@@ -1,8 +1,8 @@
 'use strict';
+const common = require('../common');
 const path = require('path');
 const assert = require('assert');
 const spawn = require('child_process').spawn;
-const common = require('../common');
 const debug = require('_debugger');
 
 var scenarios = [];

test/debugger/test-debugger-client.js

@@ -1,9 +1,9 @@
 'use strict';
-process.env.NODE_DEBUGGER_TIMEOUT = 2000;
-var common = require('../common');
+const common = require('../common');
 var assert = require('assert');
 var debug = require('_debugger');
 
+process.env.NODE_DEBUGGER_TIMEOUT = 2000;
 var debugPort = common.PORT;
 debug.port = debugPort;
 var spawn = require('child_process').spawn;

test/disabled/test-dgram-send-error.js

@@ -7,10 +7,10 @@
 // we also send packets to ourselves to verify that after receiving an error
 // we can still receive packets successfully.
 
+const common = require('../common');
 var ITERATIONS = 1000;
 
 var assert = require('assert'),
-    common = require('../common'),
     dgram = require('dgram');
 
 var buf = Buffer.alloc(1024, 42);

test/gc/test-http-client-connaborted.js

@@ -2,13 +2,14 @@
 // just like test/gc/http-client.js,
 // but aborting every connection that comes in.
 
+require('../common');
+
 function serverHandler(req, res) {
   res.connection.destroy();
 }
 
 const http = require('http');
 const weak = require('weak');
-require('../common');
 const assert = require('assert');
 const todo = 500;
 let done = 0;

test/gc/test-http-client-onerror.js

@@ -2,6 +2,8 @@
 // just like test/gc/http-client.js,
 // but with an on('error') handler that does nothing.
 
+require('../common');
+
 function serverHandler(req, res) {
   req.resume();
   res.writeHead(200, {'Content-Type': 'text/plain'});
@@ -10,7 +12,6 @@ function serverHandler(req, res) {
 
 const http = require('http');
 const weak = require('weak');
-require('../common');
 const assert = require('assert');
 const todo = 500;
 let done = 0;

test/gc/test-http-client-timeout.js

@@ -2,6 +2,8 @@
 // just like test/gc/http-client.js,
 // but with a timeout set
 
+require('../common');
+
 function serverHandler(req, res) {
   setTimeout(function() {
     req.resume();
@@ -12,7 +14,6 @@ function serverHandler(req, res) {
 
 const http = require('http');
 const weak = require('weak');
-require('../common');
 const assert = require('assert');
 const todo = 550;
 let done = 0;

test/gc/test-http-client.js

@@ -1,14 +1,15 @@
 'use strict';
 // just a simple http server and client.
 
+require('../common');
+
 function serverHandler(req, res) {
   res.writeHead(200, {'Content-Type': 'text/plain'});
   res.end('Hello World\n');
 }
 
 const http = require('http');
 const weak = require('weak');
-require('../common');
 const assert = require('assert');
 const todo = 500;
 let done = 0;

test/gc/test-net-timeout.js

@@ -2,6 +2,8 @@
 // just like test/gc/http-client-timeout.js,
 // but using a net server/client instead
 
+require('../common');
+
 function serverHandler(sock) {
   sock.setTimeout(120000);
   sock.resume();
@@ -19,7 +21,6 @@ function serverHandler(sock) {
 
 const net = require('net');
 const weak = require('weak');
-require('../common');
 const assert = require('assert');
 const todo = 500;
 let done = 0;

test/parallel/test-child-process-disconnect.js

@@ -1,6 +1,6 @@
 'use strict';
+const common = require('../common');
 var assert = require('assert');
-var common = require('../common');
 var fork = require('child_process').fork;
 var net = require('net');