@@ -473,13 +473,6 @@ function socketErrorListener(err) {
473
473
socket . destroy ( ) ;
474
474
}
475
475
476
- function freeSocketErrorListener ( err ) {
477
- const socket = this ;
478
- debug ( 'SOCKET ERROR on FREE socket:' , err . message , err . stack ) ;
479
- socket . destroy ( ) ;
480
- socket . emit ( 'agentRemove' ) ;
481
- }
482
-
483
476
function socketOnEnd ( ) {
484
477
const socket = this ;
485
478
const req = this . _httpMessage ;
@@ -658,8 +651,11 @@ function responseKeepAlive(req) {
658
651
socket . removeListener ( 'error' , socketErrorListener ) ;
659
652
socket . removeListener ( 'data' , socketOnData ) ;
660
653
socket . removeListener ( 'end' , socketOnEnd ) ;
661
- socket . once ( 'error' , freeSocketErrorListener ) ;
662
- // There are cases where _handle === null. Avoid those. Passing null to
654
+
655
+ // TODO(ronag): Between here and emitFreeNT the socket
656
+ // has no 'error' handler.
657
+
658
+ // There are cases where _handle === null. Avoid those. Passing undefined to
663
659
// nextTick() will call getDefaultTriggerAsyncId() to retrieve the id.
664
660
const asyncId = socket . _handle ? socket . _handle . getAsyncId ( ) : undefined ;
665
661
// Mark this socket as available, AFTER user-added end
@@ -741,7 +737,6 @@ function tickOnSocket(req, socket) {
741
737
}
742
738
743
739
parser . onIncoming = parserOnIncomingClient ;
744
- socket . removeListener ( 'error' , freeSocketErrorListener ) ;
745
740
socket . on ( 'error' , socketErrorListener ) ;
746
741
socket . on ( 'data' , socketOnData ) ;
747
742
socket . on ( 'end' , socketOnEnd ) ;
@@ -781,6 +776,8 @@ function listenSocketTimeout(req) {
781
776
}
782
777
783
778
ClientRequest . prototype . onSocket = function onSocket ( socket ) {
779
+ // TODO(ronag): Between here and onSocketNT the socket
780
+ // has no 'error' handler.
784
781
process . nextTick ( onSocketNT , this , socket ) ;
785
782
} ;
786
783
0 commit comments