Skip to content

Commit 4ebbc9e

Browse files
committed
dep: remove mkdirp dependency
* dep: mkdirp hasn't been updated in 4 years, and node's fs library has had a recursive option for `fs` since v10.12 (oldest active LTS version). Additionally `mkdirp` depends on a version of library `minimist` that has a minor vulnerability associated. Refs: * https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback * https://npmjs.com/advisories/1179
1 parent a96c7b5 commit 4ebbc9e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lib/configure.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
'use strict'
22

3+
const nodeFs = require('fs')
34
const fs = require('graceful-fs')
45
const path = require('path')
56
const log = require('npmlog')
67
const os = require('os')
7-
const mkdirp = require('mkdirp')
88
const processRelease = require('./process-release')
99
const win = process.platform === 'win32'
1010
const findNodeDirectory = require('./find-node-directory')
@@ -73,7 +73,8 @@ function configure (gyp, argv, callback) {
7373

7474
function createBuildDir () {
7575
log.verbose('build dir', 'attempting to create "build" dir: %s', buildDir)
76-
mkdirp(buildDir, function (err, isNew) {
76+
77+
nodeFs.mkdir(buildDir, { recursive: true }, function (err, isNew) {
7778
if (err) {
7879
return callback(err)
7980
}

lib/install.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict'
22

3+
const nodeFs = require('fs')
34
const fs = require('graceful-fs')
45
const os = require('os')
56
const tar = require('tar')
@@ -8,7 +9,6 @@ const crypto = require('crypto')
89
const log = require('npmlog')
910
const semver = require('semver')
1011
const request = require('request')
11-
const mkdir = require('mkdirp')
1212
const processRelease = require('./process-release')
1313
const win = process.platform === 'win32'
1414
const getProxyFromURI = require('./proxy')
@@ -114,7 +114,7 @@ function install (fs, gyp, argv, callback) {
114114
log.verbose('ensuring nodedir is created', devDir)
115115

116116
// first create the dir for the node dev files
117-
mkdir(devDir, function (err, created) {
117+
nodeFs.mkdir(devDir, { recursive: true }, function (err, created) {
118118
if (err) {
119119
if (err.code === 'EACCES') {
120120
eaccesFallback(err)
@@ -310,7 +310,7 @@ function install (fs, gyp, argv, callback) {
310310
log.verbose(name, 'dir', dir)
311311
log.verbose(name, 'url', libUrl)
312312

313-
mkdir(dir, function (err) {
313+
nodeFs.mkdir(dir, { recursive: true }, function (err) {
314314
if (err) {
315315
return done(err)
316316
}

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"env-paths": "^2.2.0",
2626
"glob": "^7.1.4",
2727
"graceful-fs": "^4.2.2",
28-
"mkdirp": "^0.5.1",
2928
"nopt": "^4.0.1",
3029
"npmlog": "^4.1.2",
3130
"request": "^2.88.0",

0 commit comments

Comments
 (0)