Skip to content
This repository was archived by the owner on Jul 6, 2018. It is now read-only.

Commit 0ad8120

Browse files
sebdeckersjasnell
authored andcommitted
http2: request.socket|connection
Support the socket/connection getter like require('http') does. PR-URL: #130 Reviewed-By: Colin Ihrig <[email protected]>
1 parent fec03c4 commit 0ad8120

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

lib/internal/http2/compat.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,14 @@ class Http2ServerRequest extends Readable {
178178
return '2.0';
179179
}
180180

181+
get socket() {
182+
return this.stream.session.socket;
183+
}
184+
185+
get connection() {
186+
return this.socket;
187+
}
188+
181189
_read(nread) {
182190
var stream = this[kStream];
183191
if (stream) {

test/parallel/test-http2-compat-serverrequest.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
const common = require('../common');
44
const assert = require('assert');
55
const h2 = require('http2');
6+
const net = require('net');
67

78
// Http2ServerRequest should expose convenience properties
89

@@ -22,6 +23,10 @@ server.listen(0, common.mustCall(function() {
2223
assert.strictEqual(request.httpVersionMajor, expected.httpVersionMajor);
2324
assert.strictEqual(request.httpVersionMinor, expected.httpVersionMinor);
2425

26+
assert.ok(request.socket instanceof net.Socket);
27+
assert.ok(request.connection instanceof net.Socket);
28+
assert.strictEqual(request.socket, request.connection);
29+
2530
response.stream.on('finish', common.mustCall(function() {
2631
server.close();
2732
}));

0 commit comments

Comments
 (0)