Skip to content
This repository was archived by the owner on Apr 16, 2020. It is now read-only.

Commit eee6829

Browse files
committed
fixup: fix tests
1 parent 2aad9bc commit eee6829

File tree

3 files changed

+5
-17
lines changed

3 files changed

+5
-17
lines changed

test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
import module from 'module';
22

3-
const builtins = new Set(
4-
Object.keys(process.binding('natives')).filter(str =>
5-
/^(?!(?:internal|node|v8)\/)/.test(str))
6-
);
7-
83
export function dynamicInstantiate(url) {
94
const builtinInstance = module._load(url.substr(5));
105
const builtinExports = ['default', ...Object.keys(builtinInstance)];
@@ -19,7 +14,7 @@ export function dynamicInstantiate(url) {
1914
}
2015

2116
export function resolve(specifier, base, defaultResolver) {
22-
if (builtins.has(specifier)) {
17+
if (module.builtinModules.includes(specifier)) {
2318
return {
2419
url: `node:${specifier}`,
2520
format: 'dynamic'

test/fixtures/es-module-loaders/example-loader.mjs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
import url from 'url';
22
import path from 'path';
33
import process from 'process';
4+
import { builtinModules } from 'module';
45

5-
const builtins = new Set(
6-
Object.keys(process.binding('natives')).filter((str) =>
7-
/^(?!(?:internal|node|v8)\/)/.test(str))
8-
);
96
const JS_EXTENSIONS = new Set(['.js', '.mjs']);
107

118
const baseURL = new url.URL('file://');
129
baseURL.pathname = process.cwd() + '/';
1310

1411
export function resolve(specifier, parentModuleURL = baseURL /*, defaultResolve */) {
15-
if (builtins.has(specifier)) {
12+
if (builtinModules.includes(specifier)) {
1613
return {
1714
url: specifier,
1815
format: 'builtin'

test/fixtures/es-module-loaders/js-loader.mjs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
import { URL } from 'url';
2-
3-
const builtins = new Set(
4-
Object.keys(process.binding('natives')).filter(str =>
5-
/^(?!(?:internal|node|v8)\/)/.test(str))
6-
)
2+
import { builtinModules } from 'module';
73

84
const baseURL = new URL('file://');
95
baseURL.pathname = process.cwd() + '/';
106

117
export function resolve (specifier, base = baseURL) {
12-
if (builtins.has(specifier)) {
8+
if (builtinModules.includes(specifier)) {
139
return {
1410
url: specifier,
1511
format: 'builtin'

0 commit comments

Comments
 (0)