Skip to content

Update [email protected] to 8.13.0 w/ Yarn v1.12.3 and Stretch based images #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

@chorrell
Copy link
Contributor

Ideally, we should land #850 first but it looks like there are issue with generate-stackbrew-library.sh and the created tags.

Also, is the 8/architectures/ file correct?

@PeterDaveHello
Copy link
Member Author

Oh, I think we should add architectures onbuild & slim back?

@chorrell
Copy link
Contributor

Note sure. It's a complicated matrix of what Node v8.x.x supports and what the base image (jessie or stretch support)

@chorrell
Copy link
Contributor

Let's try and land #850 first. I'm off sick today though, won't be around for most of the day.

@SimenB
Copy link
Member

SimenB commented Nov 21, 2018

We need to be ready to merge updates quickly before https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/ drops. We've been a bit slow getting updates out lately (due to some updates to architectures, so makes sense, of course), so just calling it out now 🙂

@PeterDaveHello
Copy link
Member Author

Yeah, we've been slower recently. I'm not really sure about #850, looks like there is still discussion going, in this case, maybe merge this one first, and send PR to official image library after #850 rebased & merged?

@chorrell
Copy link
Contributor

Yeah, let’s get this merged

@PeterDaveHello
Copy link
Member Author

Need your approval ;)

@PeterDaveHello
Copy link
Member Author

Thanks, let's merge it a little bit later, just right after the merge commit of #918 passed the CI, so we can reuse the cache to speed up this one.

@PeterDaveHello PeterDaveHello merged commit 5e2fdc8 into nodejs:master Nov 21, 2018
@PeterDaveHello PeterDaveHello deleted the update-node.js branch November 21, 2018 15:34
@chorrell
Copy link
Contributor

@nodejs/docker Can someone do the docker hub per for this please?

@SimenB
Copy link
Member

SimenB commented Nov 25, 2018

tianon added a commit to infosiftr/stackbrew that referenced this pull request Nov 28, 2018
- `ghost`: 2.6.2, more arches (thanks to nodejs/docker-node#921)
- `joomla`: 3.9.1
- `matomo`: php-apcu to 5.1.14 (matomo-org/docker#125)
- `openjdk`: `7u181-2.6.14-2~deb8u1`
- `php`: fix arbitrary user permissions (docker-library/php#755)
- `postgres`: `dpkg-divert` config file for correctness (docker-library/postgres#529)
- `redis`: 5.0.2
- `wordpress`: add `--no-overwrite-dir` for arbitrary user (docker-library/wordpress#351)
autophagy pushed a commit to crate/official-images that referenced this pull request Dec 12, 2018
- `ghost`: 2.6.2, more arches (thanks to nodejs/docker-node#921)
- `joomla`: 3.9.1
- `matomo`: php-apcu to 5.1.14 (matomo-org/docker#125)
- `openjdk`: `7u181-2.6.14-2~deb8u1`
- `php`: fix arbitrary user permissions (docker-library/php#755)
- `postgres`: `dpkg-divert` config file for correctness (docker-library/postgres#529)
- `redis`: 5.0.2
- `wordpress`: add `--no-overwrite-dir` for arbitrary user (docker-library/wordpress#351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants