Missing out/Debug/node on test-digitalocean-ubuntu1604_sharedlibs_container-x64-*

[joyeecheung]

Reason	not ok 1 No Debug executable
Type	BUILD_FAILURE
Failed PR	2 (nodejs/node#23232, nodejs/node#23215)
Appeared	test-digitalocean-ubuntu1604_sharedlibs_container-x64-7, test-digitalocean-ubuntu1604_sharedlibs_container-x64-8
First CI	https://ci.nodejs.org/job/node-test-pull-request/17596/
Last CI	https://ci.nodejs.org/job/node-test-pull-request/17597/

Example

[joyeecheung]

Also tap2unit doesn't seem to understand the FAIL_MSG output in tap format

08:23:28 mkdir out/junit
08:23:28 tap2junit -i test.tap -o out/junit/test.xml
08:23:28 tap2junit -i cctest.tap -o out/junit/cctest.xml
08:23:29 [ubuntu1604_sharedlibs_debug_x64] $ /bin/sh -xe /tmp/jenkins2059204694532914135.sh
08:23:29 + set -x
08:23:29 + mkdir out/junit
08:23:29 + tap2junit -i test.tap -o out/junit/test.xml
08:23:29 Traceback (most recent call last):
08:23:29   File "/usr/local/bin/tap2junit", line 11, in <module>
08:23:29     sys.exit(main())
08:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 44, in main
08:23:29     result = parse(os.path.splitext(args.input.name)[0], data)
08:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 15, in parse
08:23:29     t = TestCase(test.description, None, test.yaml['duration_ms'])

[refack]

(1) is probably a subtle race bug in nodejs/node#23156
(2) there's a newer version of tap2junit that needs to be deployed to all workers.
the bug is that the add hoc TAP generator does not specify duration_ms:

02:23:27 + echo 1..1
02:23:27 + echo 'not ok 1 No Debug executable'
02:23:27 + exit -1
...
02:23:29 + tap2junit -i test.tap -o out/junit/test.xml
02:23:29 Traceback (most recent call last):
02:23:29   File "/usr/local/bin/tap2junit", line 11, in <module>
02:23:29     sys.exit(main())
02:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 44, in main
02:23:29     result = parse(os.path.splitext(args.input.name)[0], data)
02:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 15, in parse
02:23:29     t = TestCase(test.description, None, test.yaml['duration_ms'])
02:23:29 TypeError: 'NoneType' object has no attribute '__getitem__'

Fix was to make it non mandatory:
https://github.com/refack/tap2junit/blob/7d9574915148b488b23be699f2a97f6eba509160/tap2junit/__main__.py#L11

[refack]

To fix (1) we need to land nodejs/node#23182
I've temporarily made that fail be "unstable" instead of hard fail

[github-actions]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is remove or a comment is made.