Fix some small clang-tidy issues

Author: Rayman

demo/demo_ros2_fmt_logger.cpp

@@ -2,7 +2,7 @@
 
 #include <chrono>
 #include <iostream>
-#include <rclcpp/rclcpp.hpp>
+#include <rclcpp/node.hpp>
 #include <thread>
 
 #include "ros2_fmt_logger/ros2_fmt_logger.hpp"

include/ros2_fmt_logger/ros2_fmt_logger.hpp

@@ -73,7 +73,7 @@ class Logger : public rclcpp::Logger
   /**
    * @brief Construct a Logger with a specific clock for throttling features
    * @param logger The rclcpp::Logger to extend
-   * @param clock Clock pointer used for throttling functionality
+   * @param clock_ptr Clock pointer used for throttling functionality
    */
   Logger(const rclcpp::Logger & logger, const rclcpp::Clock::ConstSharedPtr clock_ptr)
   : rclcpp::Logger(logger), clock_(*clock_ptr)  // ptr is default return of get_clock()

test/test_ros2_fmt_logger.cpp

@@ -135,7 +135,7 @@ TEST_F(Ros2FmtLoggerTest, TestFatalThrottleLogging)
   // First call should log immediately
   log(1);
   EXPECT_EQ(captured_logs.size(), 1u);
-  if (captured_logs.size() >= 1) {
+  if (!captured_logs.empty()) {
     EXPECT_EQ(captured_logs[0].message, "Throttled message: 1");
     EXPECT_EQ(captured_logs[0].severity, RCUTILS_LOG_SEVERITY_FATAL);
   }
@@ -186,7 +186,7 @@ TEST_F(Ros2FmtLoggerTest, TestFatalOnChangeLogging)
   sensor_value = 200;
   log(sensor_value);
   EXPECT_EQ(captured_logs.size(), 1u);
-  if (captured_logs.size() >= 1) {
+  if (!captured_logs.empty()) {
     EXPECT_EQ(captured_logs[0].message, "Sensor value changed to: 200");
     EXPECT_EQ(captured_logs[0].severity, RCUTILS_LOG_SEVERITY_FATAL);
   }
@@ -223,7 +223,7 @@ TEST_F(Ros2FmtLoggerTest, TestFatalOnChangeWithThreshold)
   temperature = 25.5;  // Change of 5.5 from initial (20.0), above threshold
   log(temperature);
   EXPECT_EQ(captured_logs.size(), 1u);
-  if (captured_logs.size() >= 1) {
+  if (!captured_logs.empty()) {
     EXPECT_EQ(captured_logs[0].message, "Temperature: 25.5°C (threshold: 5.0)");
     EXPECT_EQ(captured_logs[0].severity, RCUTILS_LOG_SEVERITY_FATAL);
   }