Everywhere: Write dtors for types with incomplete members out-of-line

BertalanD · nico · commit 34dba9e8e4d5 · 2024-06-24T13:56:09.000+02:00
These are rejected by Clang (19) trunk as a result of llvm/llvm-project#77753. (cherry picked from commit bf1f631)
diff --git a/Userland/Libraries/LibCore/NetworkJob.cpp b/Userland/Libraries/LibCore/NetworkJob.cpp
@@ -16,6 +16,8 @@ NetworkJob::NetworkJob(Core::File& output_stream)
 {
 }
 
+NetworkJob::~NetworkJob() = default;
+
 void NetworkJob::did_finish(NonnullRefPtr<NetworkResponse>&& response)
 {
     if (is_cancelled())
diff --git a/Userland/Libraries/LibCore/NetworkJob.h b/Userland/Libraries/LibCore/NetworkJob.h
@@ -26,7 +26,7 @@ class NetworkJob : public EventReceiver {
         ProtocolFailed,
         Cancelled,
     };
-    virtual ~NetworkJob() override = default;
+    virtual ~NetworkJob() override;
 
     // Could fire twice, after Headers and after Trailers!
     Function<void(HTTP::HeaderMap const& response_headers, Optional<u32> response_code)> on_headers_received;
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.cpp b/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.cpp
@@ -2627,6 +2627,8 @@ JBIG2ImageDecoderPlugin::JBIG2ImageDecoderPlugin()
     m_context = make<JBIG2LoadingContext>();
 }
 
+JBIG2ImageDecoderPlugin::~JBIG2ImageDecoderPlugin() = default;
+
 IntSize JBIG2ImageDecoderPlugin::size()
 {
     return m_context->page.size;
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.h b/Userland/Libraries/LibGfx/ImageFormats/JBIG2Loader.h
@@ -19,7 +19,7 @@ class JBIG2ImageDecoderPlugin : public ImageDecoderPlugin {
     static bool sniff(ReadonlyBytes);
     static ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> create(ReadonlyBytes);
 
-    virtual ~JBIG2ImageDecoderPlugin() override = default;
+    virtual ~JBIG2ImageDecoderPlugin() override;
 
     virtual IntSize size() override;
 
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.cpp
@@ -988,6 +988,8 @@ JPEG2000ImageDecoderPlugin::JPEG2000ImageDecoderPlugin()
     m_context = make<JPEG2000LoadingContext>();
 }
 
+JPEG2000ImageDecoderPlugin::~JPEG2000ImageDecoderPlugin() = default;
+
 IntSize JPEG2000ImageDecoderPlugin::size()
 {
     return m_context->size;
diff --git a/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.h b/Userland/Libraries/LibGfx/ImageFormats/JPEG2000Loader.h
@@ -37,7 +37,7 @@ class JPEG2000ImageDecoderPlugin : public ImageDecoderPlugin {
     static bool sniff(ReadonlyBytes);
     static ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> create(ReadonlyBytes);
 
-    virtual ~JPEG2000ImageDecoderPlugin() override = default;
+    virtual ~JPEG2000ImageDecoderPlugin() override;
 
     virtual IntSize size() override;
 
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.cpp
@@ -748,6 +748,8 @@ TIFFImageDecoderPlugin::TIFFImageDecoderPlugin(NonnullOwnPtr<FixedMemoryStream>
     m_context = make<TIFF::TIFFLoadingContext>(move(stream));
 }
 
+TIFFImageDecoderPlugin::~TIFFImageDecoderPlugin() = default;
+
 bool TIFFImageDecoderPlugin::sniff(ReadonlyBytes bytes)
 {
     if (bytes.size() < 4)
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h b/Userland/Libraries/LibGfx/ImageFormats/TIFFLoader.h
@@ -38,7 +38,7 @@ class TIFFImageDecoderPlugin : public ImageDecoderPlugin {
     static ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> create(ReadonlyBytes);
     static ErrorOr<NonnullOwnPtr<ExifMetadata>> read_exif_metadata(ReadonlyBytes);
 
-    virtual ~TIFFImageDecoderPlugin() override = default;
+    virtual ~TIFFImageDecoderPlugin() override;
 
     virtual IntSize size() override;
 
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp b/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp
@@ -550,6 +550,8 @@ TinyVGImageDecoderPlugin::TinyVGImageDecoderPlugin(ReadonlyBytes bytes)
 {
 }
 
+TinyVGImageDecoderPlugin::~TinyVGImageDecoderPlugin() = default;
+
 ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> TinyVGImageDecoderPlugin::create(ReadonlyBytes bytes)
 {
     auto plugin = TRY(adopt_nonnull_own_or_enomem(new (nothrow) TinyVGImageDecoderPlugin(bytes)));
diff --git a/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.h b/Userland/Libraries/LibGfx/ImageFormats/TinyVGLoader.h
@@ -86,7 +86,7 @@ class TinyVGImageDecoderPlugin final : public ImageDecoderPlugin {
     virtual NaturalFrameFormat natural_frame_format() const override { return NaturalFrameFormat::Vector; }
     virtual ErrorOr<VectorImageFrameDescriptor> vector_frame(size_t index) override;
 
-    virtual ~TinyVGImageDecoderPlugin() override = default;
+    virtual ~TinyVGImageDecoderPlugin() override;
 
 private:
     TinyVGImageDecoderPlugin(ReadonlyBytes);
diff --git a/Userland/Libraries/LibJS/CyclicModule.cpp b/Userland/Libraries/LibJS/CyclicModule.cpp
@@ -24,6 +24,8 @@ CyclicModule::CyclicModule(Realm& realm, StringView filename, bool has_top_level
 {
 }
 
+CyclicModule::~CyclicModule() = default;
+
 void CyclicModule::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
diff --git a/Userland/Libraries/LibJS/CyclicModule.h b/Userland/Libraries/LibJS/CyclicModule.h
@@ -29,6 +29,8 @@ class CyclicModule : public Module {
     JS_DECLARE_ALLOCATOR(CyclicModule);
 
 public:
+    virtual ~CyclicModule() override;
+
     // Note: Do not call these methods directly unless you are HostResolveImportedModule.
     //       Badges cannot be used because other hosts must be able to call this (and it is called recursively)
     virtual ThrowCompletionOr<void> link(VM& vm) override final;
diff --git a/Userland/Libraries/LibJS/Runtime/AsyncGenerator.cpp b/Userland/Libraries/LibJS/Runtime/AsyncGenerator.cpp
@@ -34,6 +34,8 @@ AsyncGenerator::AsyncGenerator(Realm&, Object& prototype, NonnullOwnPtr<Executio
 {
 }
 
+AsyncGenerator::~AsyncGenerator() = default;
+
 void AsyncGenerator::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
diff --git a/Userland/Libraries/LibJS/Runtime/AsyncGenerator.h b/Userland/Libraries/LibJS/Runtime/AsyncGenerator.h
@@ -31,7 +31,7 @@ class AsyncGenerator final : public Object {
 
     static ThrowCompletionOr<NonnullGCPtr<AsyncGenerator>> create(Realm&, Value, ECMAScriptFunctionObject*, NonnullOwnPtr<ExecutionContext>);
 
-    virtual ~AsyncGenerator() override = default;
+    virtual ~AsyncGenerator() override;
 
     void async_generator_enqueue(Completion, NonnullGCPtr<PromiseCapability>);
     ThrowCompletionOr<void> resume(VM&, Completion completion);
diff --git a/Userland/Libraries/LibJS/SourceTextModule.cpp b/Userland/Libraries/LibJS/SourceTextModule.cpp
@@ -116,6 +116,8 @@ SourceTextModule::SourceTextModule(Realm& realm, StringView filename, Script::Ho
 {
 }
 
+SourceTextModule::~SourceTextModule() = default;
+
 void SourceTextModule::visit_edges(Cell::Visitor& visitor)
 {
     Base::visit_edges(visitor);
diff --git a/Userland/Libraries/LibJS/SourceTextModule.h b/Userland/Libraries/LibJS/SourceTextModule.h
@@ -19,6 +19,8 @@ class SourceTextModule final : public CyclicModule {
     JS_DECLARE_ALLOCATOR(SourceTextModule);
 
 public:
+    virtual ~SourceTextModule() override;
+
     static Result<NonnullGCPtr<SourceTextModule>, Vector<ParserError>> parse(StringView source_text, Realm&, StringView filename = {}, Script::HostDefined* host_defined = nullptr);
 
     Program const& parse_node() const { return *m_ecmascript_code; }
diff --git a/Userland/Libraries/LibProtocol/RequestClient.cpp b/Userland/Libraries/LibProtocol/RequestClient.cpp
@@ -14,6 +14,8 @@ RequestClient::RequestClient(NonnullOwnPtr<Core::LocalSocket> socket)
 {
 }
 
+RequestClient::~RequestClient() = default;
+
 void RequestClient::die()
 {
     // FIXME: Gracefully handle this, or relaunch and reconnect to RequestServer.
diff --git a/Userland/Libraries/LibProtocol/RequestClient.h b/Userland/Libraries/LibProtocol/RequestClient.h
@@ -25,6 +25,7 @@ class RequestClient final
 
 public:
     explicit RequestClient(NonnullOwnPtr<Core::LocalSocket>);
+    virtual ~RequestClient() override;
 
     RefPtr<Request> start_request(ByteString const& method, URL::URL const&, HTTP::HeaderMap const& request_headers = {}, ReadonlyBytes request_body = {}, Core::ProxyData const& = {});
 
diff --git a/Userland/Libraries/LibWeb/CSS/FontFace.cpp b/Userland/Libraries/LibWeb/CSS/FontFace.cpp
@@ -198,6 +198,8 @@ FontFace::FontFace(JS::Realm& realm, JS::NonnullGCPtr<WebIDL::Promise> font_stat
         m_status = Bindings::FontFaceLoadStatus::Error;
 }
 
+FontFace::~FontFace() = default;
+
 void FontFace::initialize(JS::Realm& realm)
 {
     Base::initialize(realm);
diff --git a/Userland/Libraries/LibWeb/CSS/FontFace.h b/Userland/Libraries/LibWeb/CSS/FontFace.h
@@ -35,7 +35,7 @@ class FontFace final : public Bindings::PlatformObject {
     using FontFaceSource = Variant<String, JS::Handle<WebIDL::BufferSource>>;
 
     [[nodiscard]] static JS::NonnullGCPtr<FontFace> construct_impl(JS::Realm&, String family, FontFaceSource source, FontFaceDescriptors const& descriptors);
-    virtual ~FontFace() override = default;
+    virtual ~FontFace() override;
 
     String family() const { return m_family; }
     WebIDL::ExceptionOr<void> set_family(String const&);
diff --git a/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp b/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.cpp
@@ -26,6 +26,8 @@ ImageStyleValue::ImageStyleValue(URL::URL const& url)
 {
 }
 
+ImageStyleValue::~ImageStyleValue() = default;
+
 void ImageStyleValue::load_any_resources(DOM::Document& document)
 {
     if (m_image_request)
diff --git a/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.h b/Userland/Libraries/LibWeb/CSS/StyleValues/ImageStyleValue.h
@@ -26,7 +26,7 @@ class ImageStyleValue final
     {
         return adopt_ref(*new (nothrow) ImageStyleValue(url));
     }
-    virtual ~ImageStyleValue() override = default;
+    virtual ~ImageStyleValue() override;
 
     void visit_edges(JS::Cell::Visitor& visitor) const
     {
diff --git a/Userland/Services/WebContent/ConnectionFromClient.cpp b/Userland/Services/WebContent/ConnectionFromClient.cpp
@@ -62,6 +62,8 @@ ConnectionFromClient::ConnectionFromClient(NonnullOwnPtr<Core::LocalSocket> sock
     async_notify_process_information({ ::getpid() });
 }
 
+ConnectionFromClient::~ConnectionFromClient() = default;
+
 void ConnectionFromClient::die()
 {
     Web::Platform::EventLoopPlugin::the().quit();
diff --git a/Userland/Services/WebContent/ConnectionFromClient.h b/Userland/Services/WebContent/ConnectionFromClient.h
@@ -32,7 +32,7 @@ class ConnectionFromClient final
     C_OBJECT(ConnectionFromClient);
 
 public:
-    ~ConnectionFromClient() override = default;
+    ~ConnectionFromClient() override;
 
     virtual void die() override;
 
diff --git a/Userland/Services/WebContent/PageClient.cpp b/Userland/Services/WebContent/PageClient.cpp
@@ -75,6 +75,8 @@ PageClient::PageClient(PageHost& owner, u64 id)
 #endif
 }
 
+PageClient::~PageClient() = default;
+
 void PageClient::schedule_repaint()
 {
     if (m_paint_state != PaintState::Ready) {
diff --git a/Userland/Services/WebContent/PageClient.h b/Userland/Services/WebContent/PageClient.h
@@ -29,6 +29,8 @@ class PageClient final : public Web::PageClient {
 public:
     static JS::NonnullGCPtr<PageClient> create(JS::VM& vm, PageHost& page_host, u64 id);
 
+    virtual ~PageClient() override;
+
     static void set_use_gpu_painter();
     static void set_use_experimental_cpu_transform_support();
 

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,8 @@ NetworkJob::NetworkJob(Core::File& output_stream)`
`16`	`16`	`{`
`17`	`17`	`}`
`18`	`18`
	`19`	`+NetworkJob::~NetworkJob() = default;`
	`20`	`+`
`19`	`21`	`void NetworkJob::did_finish(NonnullRefPtr<NetworkResponse>&& response)`
`20`	`22`	`{`
`21`	`23`	`if (is_cancelled())`
Original file line number	Diff line number	Diff line change
`@@ -2627,6 +2627,8 @@ JBIG2ImageDecoderPlugin::JBIG2ImageDecoderPlugin()`
`2627`	`2627`	`m_context = make<JBIG2LoadingContext>();`
`2628`	`2628`	`}`
`2629`	`2629`
	`2630`	`+JBIG2ImageDecoderPlugin::~JBIG2ImageDecoderPlugin() = default;`
	`2631`	`+`
`2630`	`2632`	`IntSize JBIG2ImageDecoderPlugin::size()`
`2631`	`2633`	`{`
`2632`	`2634`	`return m_context->page.size;`
Original file line number	Diff line number	Diff line change
`@@ -988,6 +988,8 @@ JPEG2000ImageDecoderPlugin::JPEG2000ImageDecoderPlugin()`
`988`	`988`	`m_context = make<JPEG2000LoadingContext>();`
`989`	`989`	`}`
`990`	`990`
	`991`	`+JPEG2000ImageDecoderPlugin::~JPEG2000ImageDecoderPlugin() = default;`
	`992`	`+`
`991`	`993`	`IntSize JPEG2000ImageDecoderPlugin::size()`
`992`	`994`	`{`
`993`	`995`	`return m_context->size;`
Original file line number	Diff line number	Diff line change
`@@ -748,6 +748,8 @@ TIFFImageDecoderPlugin::TIFFImageDecoderPlugin(NonnullOwnPtr<FixedMemoryStream>`
`748`	`748`	`m_context = make<TIFF::TIFFLoadingContext>(move(stream));`
`749`	`749`	`}`
`750`	`750`
	`751`	`+TIFFImageDecoderPlugin::~TIFFImageDecoderPlugin() = default;`
	`752`	`+`
`751`	`753`	`bool TIFFImageDecoderPlugin::sniff(ReadonlyBytes bytes)`
`752`	`754`	`{`
`753`	`755`	`if (bytes.size() < 4)`
Original file line number	Diff line number	Diff line change
`@@ -550,6 +550,8 @@ TinyVGImageDecoderPlugin::TinyVGImageDecoderPlugin(ReadonlyBytes bytes)`
`550`	`550`	`{`
`551`	`551`	`}`
`552`	`552`
	`553`	`+TinyVGImageDecoderPlugin::~TinyVGImageDecoderPlugin() = default;`
	`554`	`+`
`553`	`555`	`ErrorOr<NonnullOwnPtr<ImageDecoderPlugin>> TinyVGImageDecoderPlugin::create(ReadonlyBytes bytes)`
`554`	`556`	`{`
`555`	`557`	`auto plugin = TRY(adopt_nonnull_own_or_enomem(new (nothrow) TinyVGImageDecoderPlugin(bytes)));`