fix(directive): untranslated keys return the last cumputed value #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is proposal to fix the following issue #1164 This produce the same behavior as in v11.0.1, the directive use the current text/value computed by angular change detection when the keys has neither an entry in the translation file for this language, nor in the default language translation file
ocombe
approved these changes
Feb 12, 2020
ocombe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is proposal to fix the following issue
#1164
This produce the same behavior as in v11.0.1, the directive use the current text/value computed by angular change detection when the keys has neither an entry in the translation file for this language, nor in the default language translation file