Skip to content

Commit 9ff74dc

Browse files
Jesse Rolheiserocombe
authored andcommitted
fix(pipe): handle non string input (#893)
1 parent 3e0aebb commit 9ff74dc

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

projects/ngx-translate/core/src/lib/translate.pipe.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export class TranslatePipe implements PipeTransform, OnDestroy {
3737
}
3838

3939
transform(query: string, ...args: any[]): any {
40-
if (!query || query.length === 0) {
40+
if (!query || !query.length) {
4141
return query;
4242
}
4343

projects/ngx-translate/core/tests/translate.pipe.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,15 @@ describe('TranslatePipe', () => {
161161
}).toThrowError(`Wrong parameter in TranslatePipe. Expected a valid Object, received: ${param}`);
162162
});
163163

164+
it("should return given falsey or non length query", () => {
165+
translate.setTranslation('en', {"TEST": "This is a test"});
166+
translate.use('en');
167+
168+
expect(translatePipe.transform(null)).toBeNull();
169+
expect(translatePipe.transform(undefined)).toBeUndefined();
170+
expect(translatePipe.transform(1234 as any)).toBe(1234);
171+
});
172+
164173
describe('should update translations on lang change', () => {
165174
it('with fake loader', (done) => {
166175
translate.setTranslation('en', {"TEST": "This is a test"});

0 commit comments

Comments
 (0)