Support JWT auth in mergeable minions #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
suggested changes
Jul 13, 2018
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func (lbc *LoadBalancerController) findIngressesForSecret(secret string) ([]extensions.Ingress, error) { | ||
| res := []extensions.Ingress{} | ||
| func (lbc *LoadBalancerController) findIngressesForSecret(secret string) ([]extensions.Ingress, []extensions.Ingress, error) { |
There was a problem hiding this comment.
I think we should use named return types so that nonMinions and minions are not mixed up in future extensions of this method
| } | ||
|
|
||
| // we're dealing with a minion | ||
| // only JWT secrets are allowed in a minion |
There was a problem hiding this comment.
only JWT secrets are allowed in a minion->JWT secrets are only allowed in a minion
There was a problem hiding this comment.
nope, JWT secrets are allowed in both minions and non-minions
however, minions can only have JWT secrets.
isaachawley
approved these changes
Jul 25, 2018
|
Ignore the jenkins check for this one |
pleshakov
force-pushed
the
mergeable-ingresses-jwt
branch
2 times, most recently
from
b99831a to
1fd1127
Compare
Dean-Coakley
approved these changes
Aug 1, 2018
pleshakov
added
the
enhancement
pleshakov
force-pushed
the
mergeable-ingresses-jwt
branch
from
d9b924b to
fd22dde
Compare
pleshakov
force-pushed
the
mergeable-ingresses-jwt
branch
from
fd22dde to
4d809c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/nginxinc/kubernetes-ingress/tree/master/examples/jwt#example-2-a-separate-jwt-key-per-path